fix: force block/inline descrs attributes to be public - #909
Merged
Conversation
david-christiansen
pushed a commit
that referenced
this pull request
Aug 7, 2026
This came from trying to figure out failures from merging changes into the significantly-more-module-ified nightly-testing branch: any place where extension implementations were called upon was failing in the module system — they need to refer to the private definitions to operate — but none of the relevant tests had been module-ified yet. (Unfortunately there aren't good tests to be had here, because the tests would need to exist on the nightly-testing branch.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came from trying to figure out failures from merging changes into the significantly-more-module-ified nightly-testing branch: any place where extension implementations were called upon was failing in the module system — they need to refer to the private definitions to operate — but none of the relevant tests had been module-ified yet.
(Unfortunately there aren't good tests to be had here, because the tests would need to exist on the nightly-testing branch.)