fix(mismatch): Fixes date mismatch for year 2082 and 2083#67
Open
niroula-kushal wants to merge 3 commits into
Open
fix(mismatch): Fixes date mismatch for year 2082 and 2083#67niroula-kushal wants to merge 3 commits into
niroula-kushal wants to merge 3 commits into
Conversation
Contributor
Author
|
Somehow fixed the data and made it work. No idea if there is a better way, or if the core algorithm requires changes. |
bhuwantm
reviewed
May 29, 2025
| daysNumFromMinBsYear += bsDate + 1; | ||
| } else if (bsYear === 2081 && bsMonth === 12) { | ||
| daysNumFromMinBsYear += bsDate - 1; | ||
| } else if (bsYear === 2082 && bsMonth === 2) { |
There was a problem hiding this comment.
This is forcefull way of doing it, instead i think we can update the core data.
Contributor
Author
There was a problem hiding this comment.
Exactly. I guess the core maintainers have to take a crack at it. This fix is just a brute force method intended to get the job done for a couple of months. We are bound to face this issue again next year or a year after.
Member
There was a problem hiding this comment.
yes, this isn't correct. Nepali calendar data is readily available using that would simply this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for all months in those years.