Completed Forms Lab - #9
Open
cmhorsey wants to merge 3 commits into
Open
Conversation
stephenmckeon
approved these changes
Jun 15, 2024
Comment on lines
+6
to
+12
| <input | ||
| type="text" | ||
| name="search" | ||
| value={search} | ||
| placeholder="Search..." | ||
| onChange={onSearchChange} | ||
| /> |
There was a problem hiding this comment.
Suggested change
| <input | |
| type="text" | |
| name="search" | |
| value={search} | |
| placeholder="Search..." | |
| onChange={onSearchChange} | |
| /> | |
| <input | |
| type="text" | |
| name="search" | |
| value={search} | |
| placeholder="Search..." | |
| onChange={onSearchChange} | |
| /> |
Author
There was a problem hiding this comment.
Just a warning I continued to be terrible at indenting my component props until you showed me the right way on like Friday or Thursday so apologies in advance but I promise I have gotten better lol.
|
|
||
| function ItemForm(props) { | ||
| function ItemForm({ onItemFormSubmit }) { | ||
| const [newItemName, setNewItem] = useState('') |
There was a problem hiding this comment.
Try to keep the naming consistent:
const [newItem, setNewItem] = useState('')or
const [newItemName, setNewItemName] = useState('')
Comment on lines
+33
to
+37
| <select | ||
| name="category" | ||
| value={newCategory} | ||
| onChange={(e) => setNewCategory(e.target.value)} | ||
| > |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote a controlled filter and form component.