Fix: Hide navbar login form on login page to avoid duplicate UI#5760
Open
Akritiiiiiiii wants to merge 1 commit into
Open
Fix: Hide navbar login form on login page to avoid duplicate UI#5760Akritiiiiiiii wants to merge 1 commit into
Akritiiiiiiii wants to merge 1 commit into
Conversation
This PR fixes the issue where two login interfaces were displayed simultaneously on the login page.
Author
|
Ready for review. Please let me know if any improvements are needed! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the duplicate login UI on /accounts/login/ by conditionally hiding the navbar-embedded login form when the current request is for the login page.
Changes:
- Added a template conditional in the global navbar to suppress rendering of
users/loginbox_content.htmlon the login page.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <ul class="nav pull-right"> | ||
| <li> | ||
| {% include "users/loginbox_content.html" %} | ||
| {% if "/accounts/login" not in request.path %} |
Comment on lines
+19
to
+20
| {% include "users/loginbox_content.html" %} | ||
| {% endif %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where two login interfaces were displayed simultaneously on the login page.
Description
Added conditional rendering to hide the navbar login form when the user is on the
/accounts/login/page. This prevents duplicate login interfaces and improves the overall user experience.Related Issue
Closes #
Type of Change
Testing
Tested locally:
/accounts/login/→ only main login form is visibleAI Disclosure
Used AI assistance to help understand the issue and structure the fix, but the implementation and testing were done manually.
Checklist
Closes [Feature]: Hide duplicate login form in navbar on login page #4998