-
Notifications
You must be signed in to change notification settings - Fork 20
chore(mobile): add comprehensive maestro E2E tests #2091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pete-watters
wants to merge
21
commits into
dev
Choose a base branch
from
chore/maestro-e2e-tests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
e942f50
fix: inscription test
pete-watters a1eff64
feat(mobile): restore developer console and restructure Maestro tests
pete-watters f0d2f60
fix(mobile): restore homeDeveloperToolsButton testID and fix Maestro …
pete-watters 28485e3
ci(mobile): add code-quality gate before EAS build validation
pete-watters 9eb3f7a
fix(mobile): revert gitignore change that caused EAS fingerprint drift
pete-watters 3371afb
ci(mobile): scope build validation to mobile dependencies and gate on…
pete-watters 70fae6d
fix: rebase
pete-watters 3cb31a6
fix(mobile): correct Maestro network switch-back selector
pete-watters bb86f5e
fix(mobile): use text selector for create wallet button in Maestro tests
pete-watters 4c1d7c2
fix(mobile): remove nonexistent WalletList import from developer console
pete-watters a414efe
fix(mobile): remove unused TestId members and use dev console for CI …
pete-watters 4e78205
feat(mobile): gate dev console on EXPO_PUBLIC_ENABLE_DEV_CONSOLE env var
pete-watters 331a8e2
fix(mobile): use isProduction() instead of __DEV__ for dev console vi…
pete-watters 8bd1bf2
ci(mobile): add development environment to EAS Update step
pete-watters 8379eb7
feat(mobile): ungated dev console and add environment debug info
pete-watters 32f565f
ci(mobile): add env debug screenshot step to Maestro CI suite
pete-watters 7c7339b
ci(mobile): add EXPO_PUBLIC_MAESTRO_CI to dev console env debug display
pete-watters fecc4fb
ci: retrigger Maestro E2E tests
pete-watters 23401f2
ci: retrigger Maestro E2E tests
pete-watters b118367
fix: inscription test
pete-watters f071429
ci(mobile): separate smoke tests from full suite with fast-fail gate
pete-watters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
apps/mobile/maestro/flows/android/010-create-wallet-sheet.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| appId: io.leather.mobilewallet | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This adds a specific test to make sure we can restore wallets from the bottom sheet. It's for Android only as iOS tests cannot use buttons in the sheet |
||
| name: "Android: Create Wallet via Sheet" | ||
| --- | ||
| - launchApp | ||
| - runFlow: ../../shared/clean-up.yaml | ||
| - tapOn: | ||
| id: 'homeCreateWalletCard' | ||
| - tapOn: 'Create new wallet' | ||
| - tapOn: | ||
| id: 'walletCreationTapToReveal' | ||
| - tapOn: | ||
| id: 'walletCreationBackedUpButton' | ||
| - tapOn: 'Skip for now' | ||
| - tapOn: 'Proceed' | ||
| - assertVisible: | ||
| id: 'homeAccountCard-0' | ||
18 changes: 18 additions & 0 deletions
18
apps/mobile/maestro/flows/android/020-restore-wallet-sheet.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| appId: io.leather.mobilewallet | ||
| name: "Android: Restore Wallet via Sheet" | ||
| --- | ||
| - launchApp | ||
| - runFlow: ../../shared/clean-up.yaml | ||
| - tapOn: | ||
| id: 'homeCreateWalletCard' | ||
| - tapOn: | ||
| id: 'restoreWalletSheetButton' | ||
| - tapOn: | ||
| id: 'restoreWalletTextInput' | ||
| - inputText: 'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon cactus' | ||
| - tapOn: | ||
| id: 'restoreWalletContinue' | ||
| - tapOn: 'Skip for now' | ||
| - tapOn: 'Proceed' | ||
| - assertVisible: | ||
| id: 'homeAccountCard-0' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sure we don't run the build too often by making sure the other standard checks have passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it’s good to help not be wasteful with the builds