Allow using different classes for each setting#87
Merged
ledermann merged 4 commits intoledermann:masterfrom Jul 30, 2018
Merged
Allow using different classes for each setting#87ledermann merged 4 commits intoledermann:masterfrom
ledermann merged 4 commits intoledermann:masterfrom
Conversation
added 2 commits
July 27, 2018 13:15
Prior to this, only one class name could be used for all settings within a Rails model.
Contributor
Author
|
I'll take care of these build errors when I get a chance. Please ignore the PR for now. |
Contributor
Author
|
Tests are finally passing, but I think I'll just add some more tests to cover persistence thoroughly. |
Contributor
Author
|
Hi @ledermann, first off thanks for your work on this gem, it's been super handy for us. Please let me know what you think of this PR, if you're willing to support the feature I propose it'd be great. |
Owner
|
Great work, thanks! |
Owner
|
Hm, the changes break my own application using RailsSettings, so I reverted them. Sadly I don't have the time to investigate... |
Contributor
Author
|
What versions of Ruby & Rails are you using? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update will allow us to set a custom
:class_namefor each setting. For example:This also accidentally solves #57 .