[IMP] dms: CI artifact pipeline + Hoot suite + OWL 19.0 audit + toolbar collapse - #5
Closed
dnplkndll wants to merge 0 commit into
Closed
[IMP] dms: CI artifact pipeline + Hoot suite + OWL 19.0 audit + toolbar collapse#5dnplkndll wants to merge 0 commit into
dnplkndll wants to merge 0 commit into
Conversation
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
2 times, most recently
from
May 25, 2026 16:26
1fd4f3c to
8df0b39
Compare
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
from
May 25, 2026 19:10
123ee79 to
7fec59a
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
from
May 25, 2026 19:10
8df0b39 to
fab55e7
Compare
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
from
May 25, 2026 19:33
7fec59a to
bac1c4c
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
from
May 25, 2026 19:33
fab55e7 to
3aeb0f9
Compare
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
from
May 25, 2026 19:39
bac1c4c to
7376dd1
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
from
May 25, 2026 19:39
3aeb0f9 to
4114437
Compare
dnplkndll
added a commit
that referenced
this pull request
May 25, 2026
The new module addition (dms_libreoffice_preview) pushed after a burst of activity on PR #3 / PR #5 today \u2014 GitHub's anti-abuse heuristic silently dropped the pull_request trigger for PR #6. workflow_dispatch lets us `gh workflow run` manually when this happens. Same pattern used on the 19.0-imp-dms-ux + 19.0-ci-ui-artifacts branches.
dnplkndll
added a commit
that referenced
this pull request
May 25, 2026
The new module addition (dms_libreoffice_preview) pushed after a burst of activity on PR #3 / PR #5 today \u2014 GitHub's anti-abuse heuristic silently dropped the pull_request trigger for PR #6. workflow_dispatch lets us `gh workflow run` manually when this happens. Same pattern used on the 19.0-imp-dms-ux + 19.0-ci-ui-artifacts branches.
dnplkndll
added a commit
that referenced
this pull request
May 25, 2026
The new module addition (dms_libreoffice_preview) pushed after a burst of activity on PR #3 / PR #5 today \u2014 GitHub's anti-abuse heuristic silently dropped the pull_request trigger for PR #6. workflow_dispatch lets us `gh workflow run` manually when this happens. Same pattern used on the 19.0-imp-dms-ux + 19.0-ci-ui-artifacts branches.
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
from
May 25, 2026 22:09
7376dd1 to
e0eb62c
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
from
May 25, 2026 22:10
4114437 to
bfa5049
Compare
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
from
May 25, 2026 22:31
e0eb62c to
bceef7c
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
from
May 25, 2026 22:31
bfa5049 to
1096edf
Compare
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
2 times, most recently
from
May 25, 2026 23:21
095f9d7 to
e8ffea4
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
2 times, most recently
from
May 25, 2026 23:23
57007b4 to
a383191
Compare
dnplkndll
force-pushed
the
19.0-imp-dms-ux
branch
from
May 25, 2026 23:34
e8ffea4 to
cbb1ac7
Compare
dnplkndll
force-pushed
the
19.0-ci-ui-artifacts
branch
from
May 25, 2026 23:34
a383191 to
cbb1ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of ledoent/dms#3. Fork-only PR for runboat preview + stakeholder review of CI and UX iteration that landed since #3 was force-pushed at
123ee79.What shipped
CI artifact pipeline (test failure observability)
Upload screenshots from JS testsstep (capture/tmp/odoo_tests/<DB>on failure) — forward-ported from the cookiecutter; companion template PR at ledoent/oca-addons-repo-template#1.Upload odoo server log on failurestep (capture/var/log/odoo/*.log+ workspace + runner-temp).workflow_dispatch:added so we can manually re-trigger when GitHub silently throttles fork-PR runs after a push burst.checklog-odoo.cfgignoresKilling chrome descendantsWARN (benignbrowser_jscleanup;OCA_ENABLE_CHECKLOG_ODOO=1was treating it as a build error).Hoot test suite (test_hoot.py +
?filter="@dms")tests/test_hoot.pywiresHttpCase.browser_js("/web/tests?...&filter=\"@dms\"")— Hoot's?filter=defaults to fuzzy character-order matching; the double-quoted exact-substring form isolates@dms/...test paths from the bundled web-core suite.web.assets_backend(notweb.assets_unit_tests_setup— that bundle is Hoot's framework contract; appending addon files after it breaks the runner).dms_stat_bar.test.js(sparkline geometry)file_preview_pane.test.js(toolbar / load / dispatch +expect.errors(1) + verifyErrors(patterns))file_kanban_buttons.test.js,file_kanban_density.test.js,file_kanban_mount.test.js(defineMailModels()for mock-server base, regex-literal + boolean-attr regression locks)file_list_renderer.xml-touching renderer tests underviews/preview_handlers.test.js,preview_registry.test.jsOWL 19.0 readiness audit (per oca-review U/T pattern catalog)
Two real bugs, one style sweep:
static/src/js/views/file_kanban_controller.{xml,esm.js}. The XML defineddms.FileKanbanView.Buttonsviat-inherit="web.KanbanView.Buttons"— the exact pattern that crashes at OWL render against 19.0's emptied template. Not wired anywhere; the view uses the self-containeddms.KanbanButtonstemplate.t-att-data-loadingcoerced to explicit'true'/'false'. SCSS selector&[data-loading="true"]never matched because Owl serializes truthy booleans as a presence flag (<div data-loading>).Foo.template = "x"; Foo.props = {...}) to OWL 2 static class fields across 7 components. Cross-fileRenderer.template = "..."assignments lifted into the renderer class declarations where they belong.View-toolbar collapse (overlap fix)
Both renderers were stacking four absolute-positioned floaters in the top-right corner: preview-toggle pill (kanban + list), density toggle (twice — once in
file_kanban.scss, once shifted toright: 160pxinside the kanban-split context). On list view the pill landed on top of the column-header row immediately under Odoo's control panel; on kanban the density and preview pills fought for the same corner and density was hidden entirely when the pane opened.Replaced the cascade with
.o_dms_view_toolbar— one in-flow strip above the grid/list, populated with whatever view-level controls each renderer needs (density btn-group + preview pill on kanban; preview pill only on list, right-anchored via__spacer { flex: 1 }). Gone: 4 absolute-position rules, 2right: calc(40% + 12px)shifts, 1display: nonedensity hack, all z-index battles.Backend e2e tour
dms/tests/test_backend_tours.py::test_kanban_density_toggledrivesstart_tour("/odoo", "dms_kanban_density_tour", login="admin"). Five steps verify default density → click Compact → localStorage persistence + data-attr propagation → restore Comfortable → cleanup. Toolbar chrome renders even with zero records, so the tour is safe under OCA CI's--without-demo=all.Out of scope (still deferred)
workflow_dispatch:from the workflow file before upstreaming — needed because ledoent/oca-addons-repo-template#1 hasn't landed in OCA yet.DMS — Migration & Modernizationfile refresh to mirror these surfaces — separate session.OCA/dms— blocked on OCA/dms#475 merging + the 19.0.1.0.0 wheel publishing.