fix(commands): resolve all /compact and /model review issues

[leduckhc]

Fixes all 7 issues identified in the /compact and /model command review, plus 3 findings from a GPT 5.5 second-pass review and the PR CI failures.

Changes

Wire protocol — new session.action_error event

• server/src/protocol.ts + server/src/protocol/codec.ts: add "session.action_error" to EventKind
• app/lib/transport/protocol.dart: add sessionActionError with wire string "session.action_error"
• Both fixture files updated; contract tests updated

pino-mirror.ts — error handling in runAction

• /compact silent no-op fixed: guard !lastCtx, emit emitActionError("compact", "session not ready")
• /compact async failure fixed: wrap compact() in Promise.resolve().catch() — if it rejects, emit the error back
• /model lookup failure fixed: emit error when modelRegistry.find() returns undefined
• /model promise rejection fixed: void pi.setModel(...).then(...).catch(...) — explicit fire-and-forget with error emission

Client store — session.action_error handling

• ActionError class in models.dart (SRP: domain model, not store logic)
• StoreState.actionErrors: Map<String, ActionError> — same pattern as meta
• Reducer handles sessionActionError: advances cursor, stores per-session, adds no chat item
• sessionActionErrorProvider family provider
• foldEvents switch covers sessionActionError (no chat item)

Session screen — error snackbar

• ref.listen(sessionActionErrorProvider(...)) shows "<action> failed: <reason>" snackbar on new errors (seq-guarded)

client_commands.dart — fixes

• /compact null-meta guard: "Not available for this session" for non-host sessions
• /compact snackbar: "Compact requested" (non-confirmatory)
• /model re-select guard: re-reads sessionMetaProvider after the picker await (fixes stale-capture bug found in review)
• /model snackbar: "Switching to ${name}…" (non-confirmatory)

CI fixes

• Root cause fix(commands): resolve all /compact and /model review issues #1: workflow pinned Flutter 3.22.0 / Dart 3.4.0, but app/pubspec.yaml requires Dart >=3.10.0 and Flutter >=3.38.0, so all three Flutter CI jobs failed during dependency resolution
• Root cause feat: rich tool detail views for read/write/bash/grep #2: after updating the SDK, flutter pub get --offline failed because the fresh GitHub runner cache did not contain all locked packages (flutter_native_splash)
• Updated Flutter workflow pin to 3.44.4
• Replaced flutter pub get --offline with flutter pub get --enforce-lockfile, preserving lockfile integrity while allowing cache misses to fetch from pub.dev
• Removed obsolete flutter pub outdated --mode=null-safety flag unsupported by current Flutter
• Applied Dart formatter output required by the newer SDK's format gate
• Removed accidental server/package-lock.json; server uses pnpm-lock.yaml

Tests

• client_commands_test.dart: /model added to builtin registration test
• store_reducer_test.dart: new test for session.action_error reducer path

Issue map

#	Issue	Resolution
1	/compact silent no-op when lastCtx undefined	Guard + emitActionError
2	/model promise rejection swallowed	void .then().catch() + emitActionError
3	/model model-lookup failure silent	Null check + emitActionError
4	Both: optimistic snackbars with no error path	Non-confirmatory wording + session.action_error → error snackbar
5	Both: silent no-op on non-host sessions	Null-meta guard on /compact
6	/model allows re-selecting current model	Re-select guard (reads fresh meta post-await)
7	/model missing from registration test	Added
R1	Stale meta in re-select check	Re-read provider after await _pickModel
R2	compact() async failures not caught	Promise.resolve().catch() wrapping
R3	Floating Promise on setModel chain	void prefix
CI1	Flutter checks failing due old SDK	Workflow SDK pin updated to Flutter 3.44.4
CI2	Flutter checks failing due offline cache miss	Use --enforce-lockfile instead of --offline

Verification

app: flutter pub get --enforce-lockfile
app: flutter analyze --no-pub
app: dart format --output=none --set-exit-if-changed lib test
app: flutter test --coverage
app: flutter pub outdated
server: corepack enable && pnpm install --frozen-lockfile && pnpm test

  

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.