Fix target triple for MAC_CATALYST_UNIVERSAL builds #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My apologies for this AI-generated PR. I am the maintainer of https://github.com/wcandillon/react-native-webgpu and we've always relied on ios-cmake for our CMake builds. It has been tremendously helpful. This AI-generated change helped us fix our macOS build. Below is the AI-generated description of the change: ``` ## Problem When building for `MAC_UNIVERSAL` platform, CMake fails with the error: clang: error: version 'arm64' in target triple 'arm64-apple-macosx11.0-arm64' is invalid This occurs because the toolchain generates an invalid target triple `x86_64-arm64-apple-macosx11.0` by combining multiple architectures with dashes, which clang cannot parse. ## Root Cause The `MAC_UNIVERSAL` configuration was setting `APPLE_TARGET_TRIPLE_INT` to `${ARCHS_SPLIT}-apple-macosx${DEPLOYMENT_TARGET}` where `ARCHS_SPLIT` becomes `x86_64-arm64`. This creates an invalid target triple format that clang rejects. ## Solution Remove the target triple setting for `MAC_UNIVERSAL` builds and let CMake handle the universal build using the standard `-arch x86_64 -arch arm64` approach. This follows the same pattern used by other COMBINED builds in the toolchain. Universal builds should rely on the `-arch` flags rather than target triples, as: - Target triples are meant for single architectures - Universal builds are handled at the linker level by combining object files from different architectures - CMake's built-in universal build support works correctly without explicit target triples ```
leetal
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build for MAC_CATALYST_UNIVERSAL.