Removed manual arch setting for ASM #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when generating fat builds. Since
CMAKE_OSX_ARCHITECTURESis a semicolon separated list, CMake will generate the invalid flag--arch x86_64;arm64, thus failing during compile. However, CMake already adds the correct space separated flags--arch x86_64 --arch arm64, making the whole manual setting redundant and error-prone.APPLE_TARGET_TRIPLE_FLAGalso is redundant and can be safely remove, CMake already handles that.I noticed this problem when trying to compile BLAKE3, due to its ASM usage. Checking the Ninja file revealed the aforementioned arch flags with the semicolon list.