Mark project constants depending on C++ version #1056
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another part of #1051, which marks important library information constants such as
TIXML2_MAJOR_VERSION,TINYXML2_MAX_ELEMENT_DEPTH, etc. asconstexprif in C++11 or later, otherwise juststatic constas before.This is a necessary first step as part of the modules proposal, as modules cannot directly export macros (as preprocessor macros are evaluated at preprocessing time, and modules can only export symbols). Furthermore, for a constant to be exportable, it must have external linkage (which is made possible with
inline constexpr). For that reason it is a separate PR from the actual modules feature PR.