DynArray::EnsureCapacity: make the overflow check survive release builds#1089
Open
Gooh456 wants to merge 1 commit into
Open
DynArray::EnsureCapacity: make the overflow check survive release builds#1089Gooh456 wants to merge 1 commit into
Gooh456 wants to merge 1 commit into
Conversation
Signed-off-by: Kyue <164024549+Gooh456@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looked into #1065. The overflow guard on
cap * 2is aTIXMLASSERT, which is a no-op outsideTINYXML2_DEBUG— so in release an overflowingcapwrapsnewAllocatedto something tiny,new T[newAllocated]succeeds with an undersized buffer, and thememcpyright after writes past it. Added a real check ahead of the multiply, left the existing assert for the debug diagnostic. Reaching the overflow boundary needscapnearSIZE_MAX/2/sizeof(T), so this is mostly hardening, not something a normal document hits — same conclusion the reporter came to.Fixes #1065. I don't have a build environment to compile-verify this locally — flagging that so it gets an extra look in CI/review rather than assuming it's clean.