Skip to content

add description to lgdo attrs#199

Merged
iguinn merged 2 commits into
legend-exp:mainfrom
ggmarshall:descriptions
Jun 1, 2026
Merged

add description to lgdo attrs#199
iguinn merged 2 commits into
legend-exp:mainfrom
ggmarshall:descriptions

Conversation

@ggmarshall
Copy link
Copy Markdown
Contributor

@ggmarshall ggmarshall commented May 18, 2026

Closes #194

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.40%. Comparing base (fea1310) to head (caec424).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   64.35%   64.40%   +0.05%     
==========================================
  Files          61       61              
  Lines        4009     4015       +6     
==========================================
+ Hits         2580     2586       +6     
  Misses       1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Propagates the optional description field from a processor recipe into the output LGDO buffer's attributes, so descriptions defined in DSP configs are persisted in output files (closes #194).

Changes:

  • When linking output buffers, copy a recipe-level description value into buf_out.attrs["description"] if present.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iguinn
Copy link
Copy Markdown
Collaborator

iguinn commented May 20, 2026

Thanks George, can you also throw a quick test into test_build_dsp? I think adding a description to at least one of the processors in tests/configs, checking that it shows up in attrs, and checking that nothing shows up in one without is all that's needed.

@iguinn iguinn merged commit 1db811f into legend-exp:main Jun 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add descriptions into output files as lgdo attrs

3 participants