Skip to content

Reduce memory usage of noise optimisation#686

Open
ggmarshall wants to merge 3 commits into
mainfrom
ggmarshall-nopt
Open

Reduce memory usage of noise optimisation#686
ggmarshall wants to merge 3 commits into
mainfrom
ggmarshall-nopt

Conversation

@ggmarshall
Copy link
Copy Markdown
Contributor

@ggmarshall ggmarshall commented Jun 1, 2026

  • Remove fft field when not needed
  • Make the fft plot process in batches to reduce memory - need lgdo update to do this

Update sample time calculation to use waveform data.
Copilot AI review requested due to automatic review settings June 1, 2026 21:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pygama/pargen/noise_optimization.py
Comment thread src/pygama/pargen/noise_optimization.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.22%. Comparing base (83bd5cb) to head (ac6fc19).

Files with missing lines Patch % Lines
src/pygama/pargen/noise_optimization.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   55.20%   56.22%   +1.02%     
==========================================
  Files          61       61              
  Lines        8354     8357       +3     
==========================================
+ Hits         4612     4699      +87     
+ Misses       3742     3658      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants