Ros2 OpenCV3 - #230
Open
klintan wants to merge 3 commits into
Open
Conversation
Author
|
@mbjelonic I know times are strange and you are probably very busy. Would love to get this one going, or some feedback on it to get this in as fast as possible :) |
Contributor
|
@klintan Thanks for your work! I will check your PR asap. |
Author
|
Just wanna circle back on this one, have you had the time to take a look at this ? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the eminent work by @kunaltyagi on PR #202 here is one for ROS2, but not as invasive. Since it still relies on the original darknet repo in use today (hopefully so that this can be merge easier).
I have another bug in Mac that I need to fix, but this should at least make it work out of the box.
Let me know if there is anything missing or any other changes needed before merge.
edit: might leave the mac bug be for a while, use make sure to disable the opencv viewing
--param image_view.enable_opencv:=false. Reason for this not working is that you can't update the ui in a background thread on mac.