CRUD mission ops#1770
Merged
Merged
Conversation
…pecifying Tagtype
…pecifying Tagtype
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ect not specified
wp99cp
requested changes
Oct 2, 2025
wp99cp
left a comment
wp99cp
left a comment
Member
There was a problem hiding this comment.
I have a last small thing to change, afterwards we can merge this PR.
| if mission_patterns and not (project_patterns or project_ids): | ||
| raise InvalidMissionQuery( | ||
| "Mission query does not uniquely determine mission. " | ||
| "When deleting by mission name, project name or id must be specified" |
Member
There was a problem hiding this comment.
Can we instead write "Project name or id must be specified when deleting by mission name" to avoid misunderstanding?
wp99cp
marked this pull request as ready for review
October 2, 2025 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue 1712