chore(deps-dev): bump @quasar/app-vite from 2.6.2 to 3.0.1 in /frontend#2324
chore(deps-dev): bump @quasar/app-vite from 2.6.2 to 3.0.1 in /frontend#2324dependabot[bot] wants to merge 1 commit into
Conversation
Greptile SummaryThis PR updates the Quasar Vite app tooling in the frontend.
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| frontend/package.json | Updates the frontend Quasar Vite app package version. |
Reviews (2): Last reviewed commit: "chore(deps-dev): bump @quasar/app-vite f..." | Re-trigger Greptile
| }, | ||
| "devDependencies": { | ||
| "@quasar/app-vite": "^2.4.1", | ||
| "@quasar/app-vite": "^3.0.0", |
There was a problem hiding this comment.
Legacy Env Reads Become Undefined
When the v3 Quasar CLI builds this app, the existing frontend/src/environment.ts still reads process.env.VUE_APP_PRODUCTION and process.env.DEV. The upgraded CLI now uses the Vite-style env path, so those legacy values can be missing and asBoolean(undefined) will throw during app startup or build initialization.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/package.json
Line: 51
Comment:
**Legacy Env Reads Become Undefined**
When the v3 Quasar CLI builds this app, the existing `frontend/src/environment.ts` still reads `process.env.VUE_APP_PRODUCTION` and `process.env.DEV`. The upgraded CLI now uses the Vite-style env path, so those legacy values can be missing and `asBoolean(undefined)` will throw during app startup or build initialization.
How can I resolve this? If you propose a fix, please make it concise.| }, | ||
| "devDependencies": { | ||
| "@quasar/app-vite": "^2.4.1", | ||
| "@quasar/app-vite": "^3.0.0", |
There was a problem hiding this comment.
Backend URL Prefix Can Disappear
This upgrade changes the client env exposure model while the app still depends on import.meta.env.BACKEND_URL, which is only exposed through a custom non-VITE_ prefix in frontend/quasar.config.ts. If the v3 config path no longer applies that custom prefix the same way, BACKEND_URL is omitted and asString(undefined) crashes the frontend before it can start.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/package.json
Line: 51
Comment:
**Backend URL Prefix Can Disappear**
This upgrade changes the client env exposure model while the app still depends on `import.meta.env.BACKEND_URL`, which is only exposed through a custom non-`VITE_` prefix in `frontend/quasar.config.ts`. If the v3 config path no longer applies that custom prefix the same way, `BACKEND_URL` is omitted and `asString(undefined)` crashes the frontend before it can start.
How can I resolve this? If you propose a fix, please make it concise.Bumps [@quasar/app-vite](https://github.com/quasarframework/quasar) from 2.6.2 to 3.0.1. - [Release notes](https://github.com/quasarframework/quasar/releases) - [Commits](https://github.com/quasarframework/quasar/compare/@quasar/app-vite-v2.6.2...@quasar/app-vite-v3.0.1) --- updated-dependencies: - dependency-name: "@quasar/app-vite" dependency-version: 3.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f432a13 to
d627808
Compare
Bumps @quasar/app-vite from 2.6.2 to 3.0.1.
Release notes
Sourced from @quasar/app-vite's releases.
... (truncated)
Commits
5faf39fchore(app-vite): Bump version73708b0fix(app-vite): Capacitor & Cordova modes -> www folder not cleaned before bui...97804d7fix(docs): highlight on the buggy safari regex engine4e917d2chore(ui/testing): remove console.log statement26d0b1fchore(create-quasar): Bump version1c41a9afix(create-quasar): correct title/label mismatch in JS app-vite template (fix...657205cchore(create-quasar): Bump versiona0db496chore(app-vite): Bump versionad02993chore(ui): Bump version230b171fix+perf(QDialog): css instead of js approach to fix page scroll loss functio...