Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"gen:docs": "node -r ts-node/register -r tsconfig-paths/register ./scripts/generate-openapi.ts"
},
"dependencies": {
"@aws-sdk/client-s3": "3.1010.0",
"@aws-sdk/client-s3": "3.1089.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Update lockfile too

This dependency is pinned to 3.1089.0, but the checked-in pnpm lockfile still resolves the backend importer to 3.1010.0 and has no 3.1089.0 entry. Workflows that run pnpm install --frozen-lockfile, and Docker builds that run pnpm fetch, can fail before the backend builds. Please regenerate and commit the pnpm lockfile with this bump.

Prompt To Fix With AI
This is a comment left during a code review.
Path: backend/package.json
Line: 24

Comment:
**Update lockfile too**

This dependency is pinned to `3.1089.0`, but the checked-in pnpm lockfile still resolves the backend importer to `3.1010.0` and has no `3.1089.0` entry. Workflows that run `pnpm install --frozen-lockfile`, and Docker builds that run `pnpm fetch`, can fail before the backend builds. Please regenerate and commit the pnpm lockfile with this bump.

How can I resolve this? If you propose a fix, please make it concise.

"@aws-sdk/client-sts": "3.1005.0",
"@kleinkram/api-dto": "workspace:*",
"@kleinkram/backend-common": "workspace:*",
Expand Down