Skip to content

Commit 8c5960b

Browse files
Update readme for new release and add deprecation warning
1 parent b8e362b commit 8c5960b

File tree

4 files changed

+22
-3
lines changed

4 files changed

+22
-3
lines changed

Diff for: README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ Environment repositories using the framework:
88
* **`Isaac Lab`** (built on top of NVIDIA Isaac Sim): https://github.com/isaac-sim/IsaacLab
99
* **`Legged-Gym`** (built on top of NVIDIA Isaac Gym): https://leggedrobotics.github.io/legged_gym/
1010

11-
The main branch supports PPO with additional features from our research.
12-
These include:
11+
The main branch supports **PPO** and **Student-Teacher Distillation** with additional features from our research. These include:
1312

1413
* [Random Network Distillation (RND)](https://proceedings.mlr.press/v229/schwarke23a.html) - Encourages exploration by adding
1514
a curiosity driven intrinsic reward.

Diff for: pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
44

55
[project]
66
name = "rsl-rl-lib"
7-
version = "2.2.4"
7+
version = "2.3.0"
88
keywords = ["reinforcement-learning", "isaac", "leggedrobotics", "rl-pytorch"]
99
maintainers = [
1010
{ name="Clemens Schwarke", email="[email protected]" },

Diff for: rsl_rl/modules/actor_critic_recurrent.py

+10
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
from __future__ import annotations
77

8+
import warnings
9+
810
from rsl_rl.modules import ActorCritic
911
from rsl_rl.networks import Memory
1012
from rsl_rl.utils import resolve_nn_activation
@@ -27,6 +29,14 @@ def __init__(
2729
init_noise_std=1.0,
2830
**kwargs,
2931
):
32+
if "rnn_hidden_size" in kwargs:
33+
warnings.warn(
34+
"The argument `rnn_hidden_size` is deprecated and will be removed in a future version. "
35+
"Please use `rnn_hidden_dim` instead.",
36+
DeprecationWarning,
37+
)
38+
if rnn_hidden_dim == 256: # Only override if the new argument is at its default
39+
rnn_hidden_dim = kwargs.pop("rnn_hidden_size")
3040
if kwargs:
3141
print(
3242
"ActorCriticRecurrent.__init__ got unexpected arguments, which will be ignored: " + str(kwargs.keys()),

Diff for: rsl_rl/modules/student_teacher_recurrent.py

+10
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
from __future__ import annotations
77

8+
import warnings
9+
810
from rsl_rl.modules import StudentTeacher
911
from rsl_rl.networks import Memory
1012
from rsl_rl.utils import resolve_nn_activation
@@ -28,6 +30,14 @@ def __init__(
2830
teacher_recurrent=False,
2931
**kwargs,
3032
):
33+
if "rnn_hidden_size" in kwargs:
34+
warnings.warn(
35+
"The argument `rnn_hidden_size` is deprecated and will be removed in a future version. "
36+
"Please use `rnn_hidden_dim` instead.",
37+
DeprecationWarning,
38+
)
39+
if rnn_hidden_dim == 256: # Only override if the new argument is at its default
40+
rnn_hidden_dim = kwargs.pop("rnn_hidden_size")
3141
if kwargs:
3242
print(
3343
"StudentTeacherRecurrent.__init__ got unexpected arguments, which will be ignored: "

0 commit comments

Comments
 (0)