Skip to content

feat: impl get national assembly schedule list #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: impl get national assembly schedule list #14

merged 3 commits into from
Aug 5, 2024

Conversation

sunrabbit123
Copy link
Collaborator

impl #6

@sunrabbit123
Copy link
Collaborator Author

? 왜 테스트 코드 내놓으라고 안뜨지

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/constant/index.ts 100.00% <ø> (ø)
src/lawmaker/getLawmakerList.ts 100.00% <100.00%> (ø)
...c/national-assembly/getNationalAssemblySchedule.ts 100.00% <100.00%> (ø)
src/types/callOpenApi.ts 100.00% <ø> (ø)

@sunrabbit123 sunrabbit123 marked this pull request as draft August 1, 2024 03:08
@sunrabbit123 sunrabbit123 marked this pull request as ready for review August 1, 2024 03:31
@sunrabbit123 sunrabbit123 mentioned this pull request Aug 1, 2024
Merged
@sunrabbit123
Copy link
Collaborator Author

sunrabbit123 commented Aug 1, 2024 •
edited
Loading

#15 가 먼저

@sunrabbit123 sunrabbit123 marked this pull request as draft August 1, 2024 03:33
@sunrabbit123 sunrabbit123 requested a review from StatPan August 1, 2024 03:33
@sunrabbit123 sunrabbit123 added this to the v0.0.1 필수 API 매핑 milestone Aug 1, 2024
@sunrabbit123 sunrabbit123 self-assigned this Aug 2, 2024
@sunrabbit123 sunrabbit123 marked this pull request as ready for review August 2, 2024 00:43
@StatPan
Copy link
Collaborator

StatPan commented Aug 2, 2024

새기능 바로 작업 드가셨군영 참고하기 좋겠다

@sunrabbit123 sunrabbit123 requested a review from mjy9088 August 5, 2024 09:05
@sunrabbit123
Copy link
Collaborator Author

@StatPan @stat-pan @mjy9088 review request

StatPan
StatPan approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@StatPan StatPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!!

@sunrabbit123 sunrabbit123 merged commit fbaedb0 into main Aug 5, 2024
2 checks passed
@sunrabbit123 sunrabbit123 deleted the feat/#6 branch August 5, 2024 09:33
@sunrabbit123 sunrabbit123 mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StatPan StatPan StatPan approved these changes

@mjy9088 mjy9088 Awaiting requested review from mjy9088

Assignees

@sunrabbit123 sunrabbit123

Labels
None yet
Projects
None yet
Milestone
v0.0.1 필수 API 매핑
Development

Successfully merging this pull request may close these issues.
2 participants
@sunrabbit123 @StatPan