Skip to content

fix: enhance translatedVariableDictionary (#17) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 10, 2024
Merged

fix: enhance translatedVariableDictionary (#17) #19

merged 6 commits into from
Aug 10, 2024

Conversation

sunrabbit123
Copy link
Collaborator

ref: #17

일단 초안
자동완성은 작동합니다.

@sunrabbit123 sunrabbit123 requested a review from StatPan August 2, 2024 09:33
@sunrabbit123 sunrabbit123 self-assigned this Aug 2, 2024
@sunrabbit123 sunrabbit123 marked this pull request as draft August 2, 2024 09:33
Signed-off-by: sunrabbit123 <[email protected]>
@sunrabbit123
Copy link
Collaborator Author

microsoft/TypeScript#33304

TemplateStringArray는 추론이 안됩니다.

해당 인터페이스를 유지하려면, template에 값이 다 비어있도록 의도해야하며, 이는 의도치않은 버그를 낳을 수 있습니다.

그렇다고 템플릿함수를 제거하고 일반적인 함수 형태를 취하자니, 그는 이쁘지않습니다.

좋은 아이디어 없읍니까?

@sunrabbit123
Copy link
Collaborator Author

근데 이거 굳이 object 형태여야하나
차피 internal에서만 갖다쓰니 export const 때려도 될 것 같은데

@sunrabbit123 sunrabbit123 marked this pull request as ready for review August 7, 2024 07:28
@sunrabbit123 sunrabbit123 requested review from StatPan and mjy9088 August 7, 2024 07:28
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/bill/getBillList.ts 100.00% <100.00%> (ø)
src/constant/translatedVariableDictionary/index.ts 100.00% <100.00%> (ø)
.../constant/translatedVariableDictionary/variable.ts 100.00% <100.00%> (ø)
src/lawmaker/getLawmakerList.ts 100.00% <ø> (ø)
...c/national-assembly/getNationalAssemblySchedule.ts 100.00% <ø> (ø)

Signed-off-by: sunrabbit123 <[email protected]>
@StatPan
Copy link
Collaborator

StatPan commented Aug 8, 2024

제가 미적 감각이 없어서 그런가
이쁜것보다는 기능적인 것에 더 집중하는 경향이..

차피 internal에서만 갖다쓰니 export const 때려도 될 것 같은데

쌉인정인 부분입니다

StatPan
StatPan previously approved these changes Aug 8, 2024
@sunrabbit123
Copy link
Collaborator Author

그럼 export const로 전수 변경 해야겠군요 트리쉐이킹을 위해

@sunrabbit123
Copy link
Collaborator Author

@StatPan 수정완

Copy link
Collaborator

@StatPan StatPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!!

@StatPan StatPan merged commit 0f168c0 into main Aug 10, 2024
2 checks passed
@StatPan StatPan deleted the fix/#17 branch August 10, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants