Feature/add riverside meeting service by lihail · Pull Request #875 · leits/MeetingBar

lihail · 2025-11-04T22:23:37Z

Status

READY

Description

Added a new meeting service: Riverside. Added both as web link (opened in browser) and as a desktop app
Fixed URL in PR template
Fixed a few typos in the repo

Closes this issue.

Checklist

Localized -> im not sure what i should do here
Added to changelog:
- Changelog View -> im not sure where to write the changes, since there is no "unreleased" title there
- CHANGELOG.md

Steps to Test or Reproduce

Build an run the app locally, and you'll be able to:

Define how to open Riverside meeting links (browser or desktop app)
Join Riverside meetings as per your choice

Summary by CodeRabbit

New Features
- Added Riverside meeting service integration with configurable browser preferences for opening Riverside meetings.
Bug Fixes
- Fixed multiple typos in repository documentation and changelog entries, including corrections to terminology and spelling.
Chores
- Updated PR template documentation path to reflect current project structure.

coderabbitai · 2025-11-04T22:23:46Z

Walkthrough

This PR adds Riverside as a new meeting service to MeetingBar. Changes include a new Riverside enum case in MeetingServices, Riverside icon assets, browser preference storage and UI controls, specialized URL opening logic with app scheme fallbacks, and documentation updates with typo corrections.

Changes

Cohort / File(s)	Change Summary
Documentation & Records `.github/pull-request-template.md`, `CHANGELOG.md`, `MeetingBar/UI/Views/Changelog/Changelog.swift`	Updated PR template checklist with new Changelog path, added unreleased entries for Riverside support and typo fixes, corrected "appereance" to "appearance" in changelog view
Asset Management `MeetingBar/Assets.xcassets/vendor-icons/riverside_icon.imageset/Contents.json`	Added new SVG asset manifest for Riverside icon
Service Implementation `MeetingBar/Services/MeetingServices.swift`	Introduced Riverside as new MeetingServices enum case with specialized URL opening logic supporting app schemes (riversidefm, riverside.fm) and browser fallback, added regex pattern for Riverside URL detection, and icon mapping
Configuration Storage `MeetingBar/Extensions/DefaultsKeys.swift`, `MeetingBar/Utilities/Constants.swift`	Added `riversideBrowser` Defaults key and `riversideAppBrowser` constant for Riverside-specific browser configuration
UI Preferences `MeetingBar/UI/Views/Preferences/LinksTab.swift`	Added Riverside browser picker control in Preferences allowing selection between system default, Riverside app, and other browsers

Sequence Diagram

sequenceDiagram
    participant User
    participant LinksTab as LinksTab UI
    participant MeetingServices
    participant RiversideApp as Riverside App
    participant NotificationCenter
    participant Browser

    User->>LinksTab: Select Riverside browser preference
    LinksTab->>DefaultsKeys: Store riversideBrowser preference
    
    User->>MeetingServices: Open Riverside meeting link
    
    alt Riverside app browser selected
        MeetingServices->>MeetingServices: Extract meeting URL
        MeetingServices->>RiversideApp: Try riversidefm:// scheme
        alt App responds
            RiversideApp-->>User: Open in Riverside app
        else App not available
            MeetingServices->>RiversideApp: Try riverside.fm:// scheme
            alt App responds
                RiversideApp-->>User: Open in Riverside app
            else Both schemes fail
                MeetingServices->>NotificationCenter: Show notification
                MeetingServices->>Browser: Open in selected browser
                Browser-->>User: Display meeting
            end
        end
    else System or other browser selected
        MeetingServices->>Browser: Open with selected browser
        Browser-->>User: Display meeting
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

MeetingBar/Services/MeetingServices.swift: New regex pattern for Riverside URL detection and multi-level fallback logic (app schemes, notification, browser) requires careful validation to ensure all pathways work as intended
MeetingBar/UI/Views/Preferences/LinksTab.swift: Verify Riverside browser picker integrates correctly with existing browser selection logic
URL scheme handling: Confirm riversidefm and riverside.fm schemes are correct and properly ordered for fallback

Possibly related PRs

add Meetecho #799: Both PRs add Riverside service support, modifying MeetingServices enum, URL regex patterns, and icon asset management in similar code paths

Suggested labels

feature, lgtm

Suggested reviewers

leits

Poem

🐰 A rabbit hops with glee so bright,
Riverside's here, what a delight!
New schemes to try, new icons too,
Meeting service dreams come true! 🌿✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding Riverside as a new meeting service. It is specific, clear, and directly reflects the primary objective of the pull request.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84e0a9f and 71c4038.

⛔ Files ignored due to path filters (1)

MeetingBar/Assets.xcassets/vendor-icons/riverside_icon.imageset/riverside_icon.svg is excluded by !**/*.svg

📒 Files selected for processing (8)

.github/pull-request-template.md (1 hunks)
CHANGELOG.md (4 hunks)
MeetingBar/Assets.xcassets/vendor-icons/riverside_icon.imageset/Contents.json (1 hunks)
MeetingBar/Extensions/DefaultsKeys.swift (1 hunks)
MeetingBar/Services/MeetingServices.swift (4 hunks)
MeetingBar/UI/Views/Changelog/Changelog.swift (1 hunks)
MeetingBar/UI/Views/Preferences/LinksTab.swift (2 hunks)
MeetingBar/Utilities/Constants.swift (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

.github/pull-request-template.md (1)

MeetingBar/App/AppDelegate.swift (1)

openChangelogWindow (217-238)

MeetingBar/Services/MeetingServices.swift (2)

MeetingBar/Extensions/URL.swift (2)

openInDefaultBrowser (51-58)

openIn (15-49)

MeetingBar/App/Notifications.swift (1)

sendNotification (131-141)

🪛 markdownlint-cli2 (0.18.1)

CHANGELOG.md

167-167: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Tests

🔇 Additional comments (1)

MeetingBar/Services/MeetingServices.swift (1)

261-278: Confirm Riverside custom scheme host handling

Switching the HTTPS link to riversidefm / riverside.fm via URLComponents keeps the host segment, so we end up asking macOS to open riversidefm://riverside.fm/studio/... (or riverside.fm://riverside.fm/...). Please double-check the desktop app actually registers those exact schemes with the host present; if it expects riversidefm://studio/... (hostless), the launch will fail and we'll always drop back to the browser. Could you confirm this against a live install and adjust the rewrite (e.g. rebuild the URL without the host when needed) if the app requires a different shape?

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

MeetingBar/Services/MeetingServices.swift

codecov · 2025-11-04T22:28:43Z

Codecov Report

❌ Patch coverage is 3.33333% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.24%. Comparing base (84e0a9f) to head (3d81a85).
⚠️ Report is 15 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
MeetingBar/Services/MeetingServices.swift	5.00%	19 Missing ⚠️
MeetingBar/UI/Views/Preferences/LinksTab.swift	0.00%	9 Missing ⚠️
MeetingBar/UI/Views/Changelog/Changelog.swift	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   26.30%   36.24%   +9.93%     
==========================================
  Files          36       48      +12     
  Lines        5645     5129     -516     
  Branches     2210     1743     -467     
==========================================
+ Hits         1485     1859     +374     
+ Misses       4103     3213     -890     
  Partials       57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lihail · 2025-11-04T22:33:04Z

@leits I would appreciate your review :)

lihail · 2025-11-30T10:52:17Z

Hey @leits, any chance you can get to this anytime soon?

lihail added 2 commits November 4, 2025 23:51

Add Riverside meeting service

55e16a4

Fix typos

6307c94

Fix URL in PR template

d214104

github-advanced-security bot found potential problems Nov 4, 2025

View reviewed changes

MeetingBar/Services/MeetingServices.swift Fixed Show fixed Hide fixed

MeetingBar/Services/MeetingServices.swift Fixed Show fixed Hide fixed

Add changes to changelog

dd233a0

Remove unnecessary spaces

71c4038

lihail marked this pull request as ready for review November 4, 2025 22:32

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 4, 2025

dosubot bot added the feature New feature or request label Nov 4, 2025

Merge branch 'master' into feature/add-riverside-meeting-service

3d81a85

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/add riverside meeting service#875

Feature/add riverside meeting service#875
lihail wants to merge 6 commits intoleits:masterfrom
lihail:feature/add-riverside-meeting-service

lihail commented Nov 4, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 4, 2025 •

edited

Loading

Uh oh!

lihail commented Nov 4, 2025

Uh oh!

lihail commented Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

lihail commented Nov 4, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status

Description

Checklist

Steps to Test or Reproduce

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lihail commented Nov 4, 2025

Uh oh!

lihail commented Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lihail commented Nov 4, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 4, 2025 •

edited

Loading

codecov bot commented Nov 4, 2025 •

edited

Loading