Add time-based color coding to countdown text#913
Open
jubin-marut wants to merge 4 commits into
Open
Conversation
dosubot
Bot
added
the
size:M
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdded a boolean preference and UI toggle to enable time-based coloring of the status bar countdown, a localization key, and status bar logic to compute and apply green/yellow/red colors based on remaining time. ChangesTime-based Status Bar Coloring
Sequence Diagram(s)sequenceDiagram
participant User
participant PrefUI as Preferences UI
participant Defaults
participant StatusBar as StatusBar Controller
participant Display as Status Bar Display
User->>PrefUI: Toggle "time color" option
PrefUI->>Defaults: Write timeBasedStatusBarColor
Defaults-->>StatusBar: Preference change notification
StatusBar->>StatusBar: Rebuild menu/title
StatusBar->>StatusBar: countdownColor(event)
alt remaining >= 15 min
StatusBar->>StatusBar: return rgba(0,128,0,0.5)
else remaining >= 5 min
StatusBar->>StatusBar: return rgba(255,215,0,0.5)
else remaining < 5 min
StatusBar->>StatusBar: return rgba(255,0,0,0.5)
end
StatusBar->>Display: Render time text with color
Display-->>User: Show colored countdown
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@MeetingBar/UI/StatusBar/StatusBarItemController.swift`:
- Around line 274-280: The time string is only appended when
Defaults[.eventTimeFormat] == .show, which causes the time to disappear if the
title is hidden but the user selected "show under title"; update the condition
around menuTitle.append so it also appends when the configured eventTimeFormat
requests showing the time under the title while the title is hidden (e.g., treat
Defaults[.eventTimeFormat] == .showUnderTitle as a valid case when title is
hidden). Adjust the if condition that currently checks
Defaults[.eventTimeFormat] and !time.isEmpty (and keep the existing time color
logic using countdownColor(for: nextEvent) and the timeStyles/menuTitle.append
calls) so the same append code runs for both explicit show and the "show under
title" scenario when title is hidden.
- Around line 552-557: The threshold checks in StatusBarItemController that
compare timeRemaining to 15*60 and 5*60 use strict greater-than, so exact 15m
and 5m values fall into the lower bucket; change the comparisons to inclusive
(use >= for the 15*60 and 5*60 comparisons or otherwise adjust the conditional
ordering) in the method that returns the color for timeRemaining so that
timeRemaining == 15*60 yields systemGreen and timeRemaining == 5*60 yields
systemYellow (refer to the timeRemaining comparisons in the color-returning
logic inside StatusBarItemController).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 03c9963e-4fc9-460a-b90e-705d8553e5ae
📒 Files selected for processing (4)
MeetingBar/Extensions/DefaultsKeys.swiftMeetingBar/Resources /Localization /en.lproj/Localizable.stringsMeetingBar/UI/StatusBar/StatusBarItemController.swiftMeetingBar/UI/Views/Preferences/AppearanceTab.swift
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 36.26% 36.17% -0.09%
==========================================
Files 48 48
Lines 5129 6670 +1541
Branches 1743 2234 +491
==========================================
+ Hits 1860 2413 +553
- Misses 3213 4200 +987
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
Author
|
Thanks for the review. Addressed the threshold off-by-one in 84e1470 — now uses Skipped the first finding about the |
genmarka076-lab
approved these changes
Apr 22, 2026
jubin-marut
force-pushed
the
feature/countdown-color-by-time
branch
from
84e1470 to
00cb036
Compare
Color the countdown timer text (e.g. "in 5m") based on time remaining until the next meeting: green >=15min, yellow >=5min, red <5min. Works in both inline and under-title display modes. Controlled by a new toggle in Preferences > Appearance > Status Bar, off by default.
jubin-marut
force-pushed
the
feature/countdown-color-by-time
branch
from
00cb036 to
52274dd
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
MeetingBarTests/StatusBarItem/MenuBuilderTests.swift (1)
260-298: ⚡ Quick winAdd explicit boundary tests for exactly 15:00 and 5:00 thresholds.
Great coverage of color bands and ongoing behavior. To lock in the recent threshold fix, add exact-boundary assertions so regressions at
15:00and5:00are caught immediately.Proposed test additions
final class CountdownColorTests: BaseTestCase { + func test_countdownColorIsGreenAtExactlyFifteenMinutes() { + let event = makeFakeEvent( + id: "GREEN_BOUNDARY", + start: Date().addingTimeInterval(15 * 60), + end: Date().addingTimeInterval(45 * 60) + ) + + XCTAssertEqual(countdownColor(for: event), .systemGreen) + } + + func test_countdownColorIsYellowAtExactlyFiveMinutes() { + let event = makeFakeEvent( + id: "YELLOW_BOUNDARY", + start: Date().addingTimeInterval(5 * 60), + end: Date().addingTimeInterval(35 * 60) + ) + + XCTAssertEqual(countdownColor(for: event), .systemYellow) + } + func test_countdownColorIsGreenWhenEventStartsAtLeastFifteenMinutesFromNow() { let event = makeFakeEvent( id: "GREEN", start: Date().addingTimeInterval(20 * 60), end: Date().addingTimeInterval(50 * 60) )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@MeetingBarTests/StatusBarItem/MenuBuilderTests.swift` around lines 260 - 298, Add two new unit tests that assert countdownColor(for:) returns the correct color exactly at the 15:00 and 5:00 thresholds: create events via makeFakeEvent with start dates of Date().addingTimeInterval(15 * 60) and Date().addingTimeInterval(5 * 60) (and appropriate end dates) and assert equality to .systemGreen for the 15-minute boundary and .systemYellow for the 5-minute boundary; follow the existing test naming style (e.g., test_countdownColorIsGreenWhenEventStartsExactlyFifteenMinutesFromNow and test_countdownColorIsYellowWhenEventStartsExactlyFiveMinutesFromNow) so the new tests mirror the ones using countdownColor(for:) and makeFakeEvent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@MeetingBarTests/StatusBarItem/MenuBuilderTests.swift`:
- Around line 260-298: Add two new unit tests that assert countdownColor(for:)
returns the correct color exactly at the 15:00 and 5:00 thresholds: create
events via makeFakeEvent with start dates of Date().addingTimeInterval(15 * 60)
and Date().addingTimeInterval(5 * 60) (and appropriate end dates) and assert
equality to .systemGreen for the 15-minute boundary and .systemYellow for the
5-minute boundary; follow the existing test naming style (e.g.,
test_countdownColorIsGreenWhenEventStartsExactlyFifteenMinutesFromNow and
test_countdownColorIsYellowWhenEventStartsExactlyFiveMinutesFromNow) so the new
tests mirror the ones using countdownColor(for:) and makeFakeEvent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5fc69e82-6383-4da5-8ac4-3ded3e5befb6
📒 Files selected for processing (1)
MeetingBarTests/StatusBarItem/MenuBuilderTests.swift
jubin-marut
force-pushed
the
feature/countdown-color-by-time
branch
from
41994fa to
a270916
Compare
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Colors the countdown timer text in the menu bar based on time remaining until the next meeting:
Works in both inline (
"Meeting in 5m") and under-title display modes. Controlled by a new toggle in Preferences > Appearance > Status Bar (Color countdown by time remaining), off by default. UsesNSColor.systemGreen/Yellow/Redso it adapts to light and dark mode.Implementation
countdownColor(for:)— free function computing color from event start/end datesupdateTitle()— splits title and time into separateNSAttributedStringsegments so the time portion can be independently coloredtimeBasedStatusBarColoruser default (Bool, defaultfalse)en.lprojSummary by CodeRabbit
New Features
Documentation
Tests