mathieu/feature/Add search field to activities in the library #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macteuts
changed the base branch from
develop
to
mathieu/feature/Add-favorites-Analytics-logs-to-library
macteuts
force-pushed
the
mathieu/feature/Add-favorites-Analytics-logs-to-library
branch
from
f4fcae0 to
0ea4823
Compare
macteuts
force-pushed
the
mathieu/feature/Add-search-field-to-activities-in-the-library
branch
from
8d1e4ac to
ddcf409
Compare
macteuts
force-pushed
the
mathieu/feature/Add-favorites-Analytics-logs-to-library
branch
2 times, most recently
from
5181778 to
4afcc45
Compare
macteuts
force-pushed
the
mathieu/feature/Add-search-field-to-activities-in-the-library
branch
from
ddcf409 to
cd8ff32
Compare
macteuts
changed the base branch from
mathieu/feature/Add-favorites-Analytics-logs-to-library
to
develop
macteuts
force-pushed
the
mathieu/feature/Add-search-field-to-activities-in-the-library
branch
5 times, most recently
from
78fe3c3 to
28aaf5d
Compare
macteuts
force-pushed
the
mathieu/feature/Add-search-field-to-activities-in-the-library
branch
2 times, most recently
from
1bc81ca to
9d2bdbb
Compare
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a native search field for the library activities view while also adding sorting and filtering capabilities.
- Added SortOption and FilterOption enums with computed label properties
- Integrated SwiftUI's .searchable modifier and menus for sort and filter options
- Updated the activities list to use filtering and sorting based on user input
Comments suppressed due to low confidence (1)
Apps/LekaApp/Sources/Views/PersonalLibrary/Library+ActivitiesView.swift:130
- When sorting by dateAdded, the code sorts the 'results' array but later returns 'mapped', which remains unsorted. Consider sorting 'mapped' instead to ensure the sorted order is reflected in the returned data.
results.sort { $0.addedAt.compare($1.addedAt) == .orderedAscending }
e3729c9 to
44b1055
Compare
macteuts
force-pushed
the
mathieu/feature/Add-search-field-to-activities-in-the-library
branch
2 times, most recently
from
f59eefc to
52ac0d4
Compare
macteuts
force-pushed
the
mathieu/feature/Add-search-field-to-activities-in-the-library
branch
from
52ac0d4 to
2c0e95b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.