✨ (LekaApp): Highlight new activity experience in Home curation#2042
Open
HPezz wants to merge 10 commits into
Open
✨ (LekaApp): Highlight new activity experience in Home curation#2042HPezz wants to merge 10 commits into
HPezz wants to merge 10 commits into
Conversation
HPezz
force-pushed
the
hugo/feature/home-new-activity-experience
branch
2 times, most recently
from
68570a9 to
49de96b
Compare
|
Add a curation-driven hero component that can open a curation item without introducing dismiss state.
HPezz
force-pushed
the
hugo/feature/home-new-activity-experience
branch
from
49de96b to
d09232d
Compare
Add a dedicated curation for the new activity experience and feature it from Home with refreshed sections.\n\ncloses #2037
HPezz
force-pushed
the
hugo/feature/home-new-activity-experience
branch
from
d09232d to
091957d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #2037
Tests
swiftformat Apps/LekaApp/Sources/Views/Components/FeaturedCurationView.swift Apps/LekaApp/Sources/Views/Curation/CurationView.swift Apps/LekaApp/Sources/Views/Curation/CurationViewFactory.swift Apps/LekaApp/Sources/Views/Curation/CurationSeeMoreFactory.swift Modules/ContentKit/Sources/Content/_NewSystem/Categories/Category+Curation.swiftswiftlint lint --config .swiftlint.yml --strict Apps/LekaApp/Sources/Views/Components/FeaturedCurationView.swift Apps/LekaApp/Sources/Views/Curation/CurationView.swift Apps/LekaApp/Sources/Views/Curation/CurationViewFactory.swift Apps/LekaApp/Sources/Views/Curation/CurationSeeMoreFactory.swift Modules/ContentKit/Sources/Content/_NewSystem/Categories/Category+Curation.swiftNotes
xcodebuild -workspace ios-monorepo.xcworkspace -scheme LekaApp -destination 'generic/platform=iOS Simulator' -configuration Debug build CODE_SIGNING_ALLOWED=NOcurrently fails because the generated project references missing existing assetModules/ContentKit/Resources/Content/resources/illustrations/accessories_pack.resource.icon.png.\n