✨ (ContentKit): Add find the right number gameplay#2046
Open
HPezz wants to merge 1 commit into
Open
Conversation
991b1ce to
c7f124d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
findTheRightNumbergameplay and TTS coordinatorCloses #2044
Tests
swiftformaton changed Swift filesswiftlint linton changed Swift filesxcodebuild test -workspace ios-monorepo.xcworkspace -scheme ContentKit -destination 'id=25471307-2912-414A-AC08-D96492A6ACD6' -only-testing:ContentKitTests/NewGameplayFindTheRightNumber_Tests -only-testing:ContentKitTests/CoordinatorGameplayModelDecode/test_FindTheRightNumberpre-commit run check_yaml_content_new_activities --files ...Note: full
xcodebuild test -scheme ContentKitcurrently fails in existingExerciseDecode.test_decodeDnDWithZonesOpenPlayFromYamlStringdue an unrelated assertion mismatch aroundminimumToSelect.