Skip to content

fix(core): performance improvements #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(core): performance improvements #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions libs/core/src/true-affected.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export const trueAffected = async ({
}

const affectedPackages = new Set<string>(changedIncludedFilesPackages);
const visitedIdentifiers = new Map<string, string[]>();
const visitedIdentifiers = new Map<string, Set<string>>();

const findReferencesLibs = (node: Node<ts.Node>) => {
const rootNode = findRootNode(node);
Expand Down Expand Up @@ -269,7 +269,6 @@ export const trueAffected = async ({
/* istanbul ignore next */
if (identifier == null) return;

const refs = identifier.findReferencesAsNodes();
const identifierName = identifier.getText();
const path = rootNode.getSourceFile().getFilePath();

Expand All @@ -278,22 +277,27 @@ export const trueAffected = async ({
);

if (identifierName && path) {
const visited = visitedIdentifiers.get(path) ?? [];
if (visited.includes(identifierName)) {
if (!visitedIdentifiers.has(path)) {
visitedIdentifiers.set(path, new Set());
}
const visited = visitedIdentifiers.get(path)!;
if (visited.has(identifierName)) {
logger.debug(
`Already visited ${chalk.bold(identifierName)} in ${chalk.bold(path)}`
);

return;
}

visitedIdentifiers.set(path, [...visited, identifierName]);
visited.add(identifierName);

logger.debug(
`Visiting ${chalk.bold(identifierName)} in ${chalk.bold(path)}`
);
}

const refs = identifier.findReferencesAsNodes();

refs.forEach((node) => {
const sourceFile = node.getSourceFile();
const pkg = getPackageNameByPath(sourceFile.getFilePath(), projects);
Expand Down