-
Notifications
You must be signed in to change notification settings - Fork 333
feat: add llama.cpp OpenVINO backend for Linux #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e9bdba2
becb691
9df3afb
24de412
52c7c8c
ae2b453
4d70b52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -200,12 +200,14 @@ static const EnvMapping env_mappings[] = { | |
| {"LEMONADE_LLAMACPP_ROCM_ARGS", "llamacpp", "rocm_args"}, | ||
| {"LEMONADE_LLAMACPP_VULKAN_ARGS", "llamacpp", "vulkan_args"}, | ||
| {"LEMONADE_LLAMACPP_CPU_ARGS", "llamacpp", "cpu_args"}, | ||
| {"LEMONADE_LLAMACPP_OPENVINO_ARGS", "llamacpp", "openvino_args"}, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. isn't this migration code? We didn't have oepnvino support before so how can you migrate?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These aren't migration-only mappings — migrate_from_env() is called on every fresh install to bootstrap config.json from env vars. All backends use the same mechanism (see LEMONADE_LLAMACPP_VULKAN_ARGS, LEMONADE_LLAMACPP_CUDA_BIN, etc.). Adding OpenVINO entries here means users who configure via env vars get them picked up on first run, consistent with the existing pattern.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could have sworn there was a discussion somewhere about axing them.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jfowers comments please
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see #2106. I'm getting rid of cruft, don't add more. |
||
| {"LEMONADE_LLAMACPP_DEVICE", "llamacpp", "device"}, | ||
| {"LEMONADE_LLAMACPP_PREFER_SYSTEM", "llamacpp", "prefer_system"}, | ||
| {"LEMONADE_LLAMACPP_ROCM_BIN", "llamacpp", "rocm_bin"}, | ||
| {"LEMONADE_LLAMACPP_VULKAN_BIN", "llamacpp", "vulkan_bin"}, | ||
| {"LEMONADE_LLAMACPP_CUDA_BIN", "llamacpp", "cuda_bin"}, | ||
| {"LEMONADE_LLAMACPP_CPU_BIN", "llamacpp", "cpu_bin"}, | ||
| {"LEMONADE_LLAMACPP_OPENVINO_BIN", "llamacpp", "openvino_bin"}, | ||
| // whispercpp | ||
| {"LEMONADE_WHISPERCPP", "whispercpp", "backend"}, | ||
| {"LEMONADE_WHISPERCPP_ARGS", "whispercpp", "args"}, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the runtime need to get installed somehow?