Skip to content

fix(windows): use ProcessManager::run_command for 7z extraction instead of system() Fixes #2313 #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Phqen1x wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −2
Open

fix(windows): use ProcessManager::run_command for 7z extraction instead of system() Fixes #2313 #2322

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e23cad
fix(windows): use ProcessManager::run_command for 7z extraction inste…
Phqen1x Jun 19, 2026
a87812b
fix(windows): log 7z extraction output on failure
Phqen1x Jun 19, 2026
334b92a
Merge branch 'main' into windows-7z-fix
kenvandine Jun 20, 2026
7b7d62e
Merge branch 'main' into windows-7z-fix
kenvandine Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/cpp/server/backends/backend_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,11 @@ namespace lemon::backends {
LOG(ERROR, backend_name) << "Error: .7z backend archives are only expected on Windows. Linux CUDA assets should be .tar.xz." << std::endl;
return false;
#endif
int result = system(command.c_str());
std::string output;
int result = lemon::utils::ProcessManager::run_command(command, output, 300);
if (result != 0) {
LOG(ERROR, backend_name) << "Extraction failed with code: " << result << std::endl;
LOG(ERROR, backend_name) << "Extraction failed with code: " << result
<< (output.empty() ? "" : " - " + output) << std::endl;
return false;
}
return true;
Expand Down
Loading