Fix: eviction_engine does not run nvidia-smi even on AMD configs anymore and some testing problems fixed.#2331
Open
GabrielReusRodriguez wants to merge 1 commit into
Conversation
…more and some testing problems fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I found some bugs on eviction engine.
First, my config is all AMD hardware and when I launched lemonade I saw this line repeated all time:
sh 1: nvidia-smi not found.
looking at code, I saw at system_info.cpp funtion double SystemInfo::get_global_vram_usage_pct() that it was always executing the call to nvidia-smi program so if somebody had amd config, it will not find this program.
I fixed making a get_cuda_arch().empty()) call to check if you have some nvidia arch on your config. If so.. it launches the code.
Second, I tryed the server_eviction.py tests. but I found some errors.
I hope these changes help.