Skip to content

README.md - Fix download links - #2827

Open
duggiefresh wants to merge 1 commit into
lemonade-sdk:mainfrom
duggiefresh:duggiefresh-fix-download-links
Open

README.md - Fix download links#2827
duggiefresh wants to merge 1 commit into
lemonade-sdk:mainfrom
duggiefresh:duggiefresh-fix-download-links

Conversation

@duggiefresh

Copy link
Copy Markdown

Update the download links to the main installation page: https://lemonade-server.ai/docs/guide/install/

[ci skip]

Update the download links to the main installation page: https://lemonade-server.ai/docs/guide/install/
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 27, 2026

@fl0rianr fl0rianr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the obsolete installation links. The general Download link looks good, but I do not think the PR is safe to merge in its current form.

The main concern is the use of automatically generated anchors such as #__tabbed_1_2. These IDs depend on the order and structure of the documentation tabs. Adding, removing, or reordering tabs could silently make the README links select the wrong platform while still appearing valid.

In addition, the distribution-specific badges now all point to the generic Linux tab. Since dedicated pages already exist, these should link directly to their respective installation instructions:

  • Arch: /docs/guide/install/arch/
  • Debian: /docs/guide/install/debian/
  • Fedora: /docs/guide/install/fedora/
  • Ubuntu: /docs/guide/install/ubuntu/
  • Docker: /docs/guide/install/docker/

This preserves the existing behavior where a platform-specific badge leads directly to platform-specific instructions.

I would therefore suggest:

  1. Keep the general Download link to /docs/guide/install/.
  2. Use the stable, dedicated pages for the distribution and Docker badges.
  3. Avoid relying on generated #__tabbed_1_n fragments for long-lived README links, unless stable named tab anchors are introduced.
  4. Rebase or update the branch and let the normal checks run, since the current runs are marked action_required.

There are also remaining install_options.html links elsewhere in the repository, especially in the FAQ. Those can be handled separately, but should be tracked as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants