README.md - Fix download links - #2827
Conversation
Update the download links to the main installation page: https://lemonade-server.ai/docs/guide/install/
fl0rianr
left a comment
There was a problem hiding this comment.
Thanks for updating the obsolete installation links. The general Download link looks good, but I do not think the PR is safe to merge in its current form.
The main concern is the use of automatically generated anchors such as #__tabbed_1_2. These IDs depend on the order and structure of the documentation tabs. Adding, removing, or reordering tabs could silently make the README links select the wrong platform while still appearing valid.
In addition, the distribution-specific badges now all point to the generic Linux tab. Since dedicated pages already exist, these should link directly to their respective installation instructions:
- Arch:
/docs/guide/install/arch/ - Debian:
/docs/guide/install/debian/ - Fedora:
/docs/guide/install/fedora/ - Ubuntu:
/docs/guide/install/ubuntu/ - Docker:
/docs/guide/install/docker/
This preserves the existing behavior where a platform-specific badge leads directly to platform-specific instructions.
I would therefore suggest:
- Keep the general Download link to
/docs/guide/install/. - Use the stable, dedicated pages for the distribution and Docker badges.
- Avoid relying on generated
#__tabbed_1_nfragments for long-lived README links, unless stable named tab anchors are introduced. - Rebase or update the branch and let the normal checks run, since the current runs are marked
action_required.
There are also remaining install_options.html links elsewhere in the repository, especially in the FAQ. Those can be handled separately, but should be tracked as a follow-up.
Update the download links to the main installation page: https://lemonade-server.ai/docs/guide/install/
[ci skip]