[llamacpp] replace deprecated flags, better IO flag handling - #2833
Draft
bitgamma wants to merge 1 commit into
Draft
[llamacpp] replace deprecated flags, better IO flag handling#2833bitgamma wants to merge 1 commit into
bitgamma wants to merge 1 commit into
Conversation
github-actions
Bot
added
engine::llamacpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace some deprecated llamacpp flags with their new version. It also handles better the IO flag overrides so that the defaults do not accidentally override whatever the user sets.
It also allows the user control the mmproj offload (when using GPU) since this is not in actual conflict with what we set.
since
--load-modewas introduced July 23rd, we need to bump llamacpp version before merging this.finally, a couple of unused constants (they are defined elsewhere) have been removed