feat(flm): add --modelscope flag to FLM backend - #2841
Conversation
3bd403c to
7ed53fd
Compare
|
Looks like CI found some problem? Please have a look. I made a 1LoC PR here for the version bump, to try and get it into today's release: #2847 We will still need this PR for the modelscope support! |
I think Hermes messed up and passed |
- Add --modelscope BOOL option to FLM backend descriptor - Wire --modelscope flag through download_model() to pass to 'flm pull --modelscope 1' (uses '1' not 'true' since FLM expects 0/1) The modelscope option (requires FLM >= v0.9.46) makes FLM resolve models from ModelScope (https://modelscope.cn) instead of HuggingFace, using the model's ms_url field.
|
@jeremyfowers modelscope should be fixed now, can you have another look please? |
|
omg is wariobot your bot? 😂 |
|
[AI-assisted review] Automated pre-review from repo-manager — flags for the human reviewer, not a replacement for one. Attention level: Elevated — any reviewer can take it, but the to-dos below need resolving before approval (PR description does not match the diff) Author's description vs. the diffThe description overstates the scope of changes and references a file that was not modified.
Scopeminor — The PR adds a single BOOL option to the existing FLM backend descriptor with 16 lines of additions across 5 files — a contained extension of an existing surface. Suggested reviewers
Reviewed at head |
Summary
Add
--modelscopeBOOL option to the FLM backend descriptor. When set to 1, passes--modelscope 1toflm pull,flm list, andflm installed-checkpointsCLI calls to resolve models from ModelScope (https://modelscope.cn) instead of HuggingFace.Changes
fastflowlm.h: AddmodelscopeBOOL option to FLM backend descriptor (defaults to"0")fastflowlm_server.h: Addmodelscopeparameter todownload_model()signaturefastflowlm_server.cpp: Readmodelscopeoption inload()and pass todownload_model()docs/dev/backends-reference.md: Document the newmodelscopeoption in FLM backend tabledocs/guide/cli.md: Document the newmodelscopeoption in CLI referenceUsage
Users can enable ModelScope downloads in their
config.json:{ "flm": { "args": "", "modelscope": 1, "prefer_system": false } }Note: FLM expects
0/1(nottrue/false) for the--modelscopeflag.This requires FLM ≥ v0.9.46 which introduces the
--modelscopeflag.