fix(docs): Added group_add configuration for ROCm support in Docker. - #2857
Open
storm1er wants to merge 5 commits into
Open
fix(docs): Added group_add configuration for ROCm support in Docker.#2857storm1er wants to merge 5 commits into
storm1er wants to merge 5 commits into
Conversation
Since lemonade v11.0.0, docker lemonade is not root anymore, so we need to give container user permission to /dev/kri and /dev/kfd
github-actions
Bot
added
the
documentation
siavashhub
requested changes
Jul 30, 2026
siavashhub
left a comment
siavashhub
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this! it's a genuinely useful addition, since the permissions got changed from 10.10 to unprivileged user (UID 10001) and that container user needs to be in the host's GPU groups for ROCm device access to work.
I've left a few suggestions to make it robust for everyone:
- Hardcoded GID 992 is host-specific: the numeric ID for render/video varies per machine, so it'll silently fail for many users. Better to use the group names and tell people how to find the numeric IDs (getent group render video) as a fallback.
- Compose block placement: the devices/group_add additions apply only to ROCm on Linux, so it's worth flagging that so non-AMD users don't copy /dev/kfd and hit errors.
Co-authored-by: Siavash Yousefi <61756513+siavashhub@users.noreply.github.com>
Co-authored-by: Siavash Yousefi <61756513+siavashhub@users.noreply.github.com>
…features Co-authored-by: Siavash Yousefi <61756513+siavashhub@users.noreply.github.com>
Collaborator
|
looks good to me |
siavashhub
enabled auto-merge
August 1, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since lemonade v11.0.0, docker lemonade is not root anymore, so we need to give container user permission to /dev/kri and /dev/kfd