Skip to content

fix: Setting the EdgeInput type to EdgeArrowType.both has no effect #35 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lempiy merged 1 commit into from
Mar 28, 2025
Merged

fix: Setting the EdgeInput type to EdgeArrowType.both has no effect #35 #36

lempiy merged 1 commit into from
Mar 28, 2025

Conversation

@fabionuno
Copy link
Contributor

@fabionuno fabionuno commented Mar 17, 2025

fix #35

This pull request includes a change to the lib/graphite_edges_painter.dart file to fix the EdgeStyle initialization by utilizing the arrowType property from the Edge object.

Codebase improvement:

  • lib/graphite_edges_painter.dart: Modified the _defaultStyleBuilder function to return an EdgeStyle with the arrowType property set to the arrowType of the provided Edge object.

@fabionuno
fix: Setting the EdgeInput type to EdgeArrowType.both has no effect l…
83f8305 
…empiy#35

fix lempiy#35

The _defaultStyleBuilder method receives an instance of Edge but does not pass the arrowType configuration to the EdgeStyle.
@lempiy
Copy link
Owner

lempiy commented Mar 28, 2025

Hi, ty. LGTM.

@lempiy lempiy merged commit ac5e372 into lempiy:master Mar 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting the EdgeInput type to EdgeArrowType.both has no effect

2 participants

@fabionuno @lempiy