ical-rs overhaul#164
Merged
Merged
Conversation
b9c2a4c to
7c15976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates a complete overhaul of my
ical-rsfork.This new
ical-rsversion is much stricter in parsing input data but also more aware of it, which is a crucial step towards JSCalendar support.Breaking changes:
Logic outsourced to the
ical-rslibrary:Todos:
todo!()object_idextrinsicobject_idfrom ETagOther improvements:
Other todos that don't need to be in this PR:
addressobjectstable (This must be in a later version since it's aAddressObject/CalendarObject