-
Notifications
You must be signed in to change notification settings - Fork 25
feature / lz gated modules #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feature / lz gated modules #26
Conversation
…t a todo on the follow test that now fails
|
…to lzgatedproxy; update tests + tasks to use estimateFees* functions
…efailed OR executes noblocking; impr: better tests for message failed; impr: updated readme for tasks; new testnet deployment
donosonaumczuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, good work!
There are lot of files that we are adding to the repo that are not necessarily ad-hoc for the Lens modules, but instead generic LayerZero contracts. It would be nice if you import your core repo as a dependency instead, or even create a separate repo that can be used as dependency if some of the files are not included in your core repo.
The idea is to avoid increasing the amount of files here when are not 100% related to the code of each of the Lens modules. Same reason why I am asking to remove some duplicated mocks from the PR.
… using LzApp instead of simpleLzApp
|
thanks for the feedback @donosonaumczuk 🙏 I resolved all comments and pushed changes
|
New features
LZGatedFollowModule,LZGatedCollectModule, andLZGatedReferenceModuleto do cross-chain token gatingLZGatedProxy,LzApp,NonblockingLzApp, andSimpleLzAppExample (
LZGatedFollowModule)#followWithSigLZGatedProxycontract on Optimism, which relays the payload to theLZGatedFollowModulecontract on Polygon via LayerZeroTODO
/lz-gated-follow-module.spec.tsMessageFailedbeing emitted when the tx actually succeeds#sendon source chain and#lzReceiveon destination chain can be between 5-30min+ (goerli => mumbai) => testnet infra was updated, not an issue on mainnet ✅