Wrap pod logs#6217
Conversation
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: alexfront <alex.andreev.email@gmail.com>
Signed-off-by: alexfront <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
|
Should the highlighted search selection stay in view when toggling wrapped? Screen.Recording.2022-12-05.at.6.38.21.PM.movAlso, when at the very bottom of the logs with Wrap logs checked, unchecking then rechecking leaves the view not at the bottom of the logs. |
| import type { DiContainer } from "@ogre-tools/injectable"; | ||
| import type { Container } from "../../common/k8s-api/endpoints"; | ||
|
|
||
| const observe = jest.fn(); |
There was a problem hiding this comment.
nit: set it inline below?
| userEvent.keyboard("o"); | ||
| userEvent.click(await screen.findByText("keyboard_arrow_up")); | ||
| expect(scrollToOverlay).toBeCalled(); | ||
| expect(setPrevOverlayActiveMock).toHaveBeenCalled(); |
There was a problem hiding this comment.
nit
| expect(setPrevOverlayActiveMock).toHaveBeenCalled(); | |
| expect(setPrevOverlayActiveMock).toBeCalled(); |
| */ | ||
| import { useState } from "react"; | ||
|
|
||
| export function useJumpToBottomButton(scrolledParent: HTMLDivElement | null): [isVisible: boolean, setVisibility: () => void] { |
There was a problem hiding this comment.
nit
| export function useJumpToBottomButton(scrolledParent: HTMLDivElement | null): [isVisible: boolean, setVisibility: () => void] { | |
| export function useScrollToBottomButton(scrolledParent: HTMLDivElement | null): [isVisible: boolean, setVisibility: () => void] { |
or change file name?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
@aleksfront Thanks for working on this! I cant wait to see this get merged and shipped. Even on a 4k screen, scrolling horizontally just to get the details you need is a massive pain. |
|
thanks for working on this |
|
Thanks for working on this man 👍 |
|
Thanks @aleksfront , it is a much needed feature. |
|
@aleksfront or @Nokel81 could one of you rebase this so it can get merged? Its a badly needed feature at this point and it would be great to finally see it in the 6.5.0 release |
|
Please help on this feature, highly requested |
Adding a way to wrap log lines for better logs readability.
This made possible by replacing
react-windowvirtualisation library totanstack/virtual(https://github.com/tanstack/virtual) which supports undetermined height rows.wrapping.logs.mov
Fixes #1077