Rework the metric interface and collection to use explicit accumulators - #1063
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 89.54% 89.49% -0.05%
==========================================
Files 229 233 +4
Lines 15870 15890 +20
==========================================
+ Hits 14210 14220 +10
- Misses 1660 1670 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdekstrand
force-pushed
the
feature/866-accumulators
branch
from
April 5, 2026 19:48
4bb57c9 to
44cd728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overhauls the metric interface and the metric collection code to use explicit accumulator objects, so different metrics can have different accumulation behavior, and allowing things like Gini to be computed with less memory consumption.
It also simplifies and deprecates
RunAnalysisin favor of directly usingMeasurementCollector.Several of the old
MeasurementCollectortests are removed because the measurement collector is responsible for much less logic now.Closes #866, #968.