Skip to content

Data cleanup: private submodules, rename AttributeSet -> EntityAttribute, type cleanup - #1067

Merged
mdekstrand merged 36 commits into
lenskit:mainfrom
mdekstrand:tweak/data-modules
Apr 7, 2026
Merged

Data cleanup: private submodules, rename AttributeSet -> EntityAttribute, type cleanup#1067
mdekstrand merged 36 commits into
lenskit:mainfrom
mdekstrand:tweak/data-modules

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

This closes #946 and advances #947 by cleaning up the lenskit.data module, making submodules private and renaming AttributeSet to EntityAttribute.

Also includes various other type cleanups.

@mdekstrand mdekstrand added this to the 2026.1 milestone Apr 6, 2026
@mdekstrand mdekstrand self-assigned this Apr 6, 2026
@mdekstrand mdekstrand added breaking data Data management support. labels Apr 6, 2026
@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.45%. Comparing base (b148ed0) to head (6c3ec66).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   89.49%   89.45%   -0.04%     
==========================================
  Files         233      233              
  Lines       15890    15870      -20     
==========================================
- Hits        14220    14197      -23     
- Misses       1670     1673       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand
mdekstrand merged commit 788839a into lenskit:main Apr 7, 2026
62 of 63 checks passed
@mdekstrand
mdekstrand deleted the tweak/data-modules branch April 7, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking data Data management support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename AttributeSet classes

1 participant