Skip to content

test: fix windows compatibility for editor spawn tests . #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XuMeng-0 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

test: fix windows compatibility for editor spawn tests . #258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions __tests__/cz-customizable.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ const getPreviousCommit = require('../lib/utils/get-previous-commit');

const commit = jest.fn();

const MOCK_EDITOR_SUCCESS = process.platform === 'win32' ? 'cmd /c exit 0' : 'true';
const MOCK_EDITOR_FAILURE = process.platform === 'win32' ? 'cmd /c exit 1' : 'false';

jest.mock('./../lib/read-config-file');
jest.mock('./../lib/utils/get-previous-commit');

Expand Down Expand Up @@ -155,7 +158,7 @@ describe('cz-customizable', () => {
});

it('should allow edit message before commit', (done) => {
process.env.EDITOR = 'true';
process.env.EDITOR = MOCK_EDITOR_SUCCESS;

const answers = {
confirmCommit: 'edit',
Expand All @@ -173,7 +176,7 @@ describe('cz-customizable', () => {
});

it('should not commit if editor returned non-zero value', (done) => {
process.env.EDITOR = 'false';
process.env.EDITOR = MOCK_EDITOR_FAILURE;

const answers = {
confirmCommit: 'edit',
Expand Down