Add WebSearchPlugin #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
requested changes
Nov 10, 2025
Owner
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Hi, thank you this looks very promising only two minor comments :)
plugins/WebSearchPlugin/Plugin.vala
Outdated
| } | ||
|
|
||
| public override async void activate () throws Error { | ||
| Process.spawn_command_line_async (@"flatpak-spawn --host xdg-open \"$url\""); |
Owner
There was a problem hiding this comment.
You can use Gtk.UriLauncher here which uses portals and doesn't need the extra permission for the flatpak-spawn --host
plugins/WebSearchPlugin/Plugin.vala
Outdated
| } | ||
|
|
||
| public override async void activate () throws Error { | ||
| Process.spawn_command_line_async (@"flatpak-spawn --host xdg-open \"$url\""); |
Contributor
Author
That's great, I'll adjust those items. Thank you very much. |
…ncher as requested in the review.
…-web-search-plugin
Contributor
Author
|
@leolost2605 I made the requested corrections. I await your review, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WebSearchPlugin, which allows you to open links directly in the system's default browser or perform searches via Google, DuckDuckGo, or Bing. Closes #1.
Search
Open URL
