docs: add llame vision and model default - #103
Conversation
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a new VISION.md document outlining the platform's core bets, current focus, and non-goals, and links it in AGENTS.md. Additionally, it updates the default OpenAI model to gpt-5.4-mini. Feedback is provided regarding a style guide violation: a dated entry must be added to CHANGELOG.md within this pull request to document these changes before merging.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ## Key documentation | ||
|
|
||
| - [README.md](README.md) — what llame is (product overview, quickstart; imported above) | ||
| - [VISION.md](VISION.md) — why llame is shaped this way, current focus, emerging directions, and what we won't build yet |
There was a problem hiding this comment.
According to the repository style guide (lines 79-84), any PR that ships work (including features, bug fixes, and chores alike) must update CHANGELOG.md with a dated entry in the same PR. Please add a dated entry to CHANGELOG.md detailing the addition of VISION.md and the update of the default OpenAI model to gpt-5.4-mini.
References
- Update both ROADMAP.md and CHANGELOG.md in the same PR that ships the work, not after. The PR's own diff adds the dated CHANGELOG.md entry. (link)
There was a problem hiding this comment.
Fixed in 6ec721b by adding the 2026-07-02 changelog entry for VISION.md, the default-model bump, and telemetry pricing. Also ran pnpm exec prettier --check CHANGELOG.md AGENTS.md VISION.md and git diff --check.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc834374aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } from './model-client'; | ||
|
|
||
| export const DEFAULT_OPENAI_MODEL = 'gpt-4o-mini'; | ||
| export const DEFAULT_OPENAI_MODEL = 'gpt-5.4-mini'; |
There was a problem hiding this comment.
Add pricing for the new default model
When users take the default OpenAI path (ChatLoopService calls createOpenAIClient(credential) without a model override), telemetry now records gpt-5.4-mini; however MODEL_TOKEN_PRICES_USD_PER_1M still only contains gpt-4o-mini, and calculateCostUsd returns null for any missing key. This means all real default chats lose persisted/logged cost data even though the previous default produced costs, so the model bump should update the pricing table or intentionally configure a priced fallback.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 7edf81c by adding gpt-5.4-mini to MODEL_TOKEN_PRICES_USD_PER_1M with a unit test for default OpenAI model pricing. Verified with pnpm --filter api test -- turn-telemetry.spec.ts; full API test/RLS/turbo gates are green locally.
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/api/src/models/openai-model-client.ts">
<violation number="1" location="apps/api/src/models/openai-model-client.ts:10">
P2: The default model is now `gpt-5.4-mini`, but cost calculation paths that rely on `MODEL_TOKEN_PRICES_USD_PER_1M` will return `null` if this model key is missing. That would drop persisted/logged cost data for default chats unless pricing for `gpt-5.4-mini` (or an explicit priced fallback) is added alongside this default bump.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| } from './model-client'; | ||
|
|
||
| export const DEFAULT_OPENAI_MODEL = 'gpt-4o-mini'; | ||
| export const DEFAULT_OPENAI_MODEL = 'gpt-5.4-mini'; |
There was a problem hiding this comment.
P2: The default model is now gpt-5.4-mini, but cost calculation paths that rely on MODEL_TOKEN_PRICES_USD_PER_1M will return null if this model key is missing. That would drop persisted/logged cost data for default chats unless pricing for gpt-5.4-mini (or an explicit priced fallback) is added alongside this default bump.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/src/models/openai-model-client.ts, line 10:
<comment>The default model is now `gpt-5.4-mini`, but cost calculation paths that rely on `MODEL_TOKEN_PRICES_USD_PER_1M` will return `null` if this model key is missing. That would drop persisted/logged cost data for default chats unless pricing for `gpt-5.4-mini` (or an explicit priced fallback) is added alongside this default bump.</comment>
<file context>
@@ -7,7 +7,7 @@ import {
} from './model-client';
-export const DEFAULT_OPENAI_MODEL = 'gpt-4o-mini';
+export const DEFAULT_OPENAI_MODEL = 'gpt-5.4-mini';
/**
</file context>
There was a problem hiding this comment.
Fixed in 7edf81c by adding gpt-5.4-mini to MODEL_TOKEN_PRICES_USD_PER_1M with a unit test for default OpenAI model pricing. Verified with pnpm --filter api test -- turn-telemetry.spec.ts; full API test/RLS/turbo gates are green locally.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Short OpenClaw-style vision doc distinct from SPEC.md's detailed architecture: the why behind the core bets, current milestone focus, emerging directions not yet spec'd (personas, machine connector, Brain memory surface, calendar/email, n8n-style workflows), and guardrails on what we won't build yet. Linked from AGENTS.md's doc index. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
cc83437 to
7edf81c
Compare
Co-Authored-By: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>
Summary
Deferred in later stack PRs
Summary by cubic
Set
gpt-5.4-minias the default OpenAI model and added its token pricing to turn telemetry, covered by a unit test. AddedVISION.md(north star, current focus, emerging directions, non-goals), linked fromAGENTS.md, and updatedCHANGELOG.md.Written for commit 6ec721b. Summary will update on new commits.