Widen accepted ref types for React 19 ref types#32
Closed
jasikpark wants to merge 2 commits intoleonardodino:mainfrom
Closed
Widen accepted ref types for React 19 ref types#32jasikpark wants to merge 2 commits intoleonardodino:mainfrom
jasikpark wants to merge 2 commits intoleonardodino:mainfrom
Conversation
React 19 alters how refs are calculated, so allowing a null ref value is needed to be explicitly allowed now.
jasikpark
changed the title
inputRef type for CodeInputProps for React 19 ref types
Owner
|
hey @jasikpark thanks for contributing this fix! 💯🙌 would you mind updating the diff to only include the intended changes, and not the formatting updates? |
Back out "Always accept null as part of a RefObject" This backs out commit 4589704. Always accept null as part of a RefObject
Contributor
Author
done! |
Owner
|
merged this changes in #34 and released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19 alters how refs are calculated, so allowing a null ref value is needed to be explicitly allowed now.
Otherwise: