Skip to content

Bump riot to >= 0.0.9 in minttea.opam #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chshersh
Copy link

The version is bumped inside dune-project but not in the minttea.opam file.

Because of this, when pinning the latest version of minttea from GitHub, I see the following error (which was very confusing to debug because it doesn't say which package has this strict constraint):

❯ opam switch create .
Package github_tui does not exist, create as a NEW package? [Y/n] y
The following additional pinnings are required by github_tui.~dev:
  - minttea.dev at git+https://github.com/leostera/minttea
  - riot.dev at git+https://github.com/riot-ml/riot
  - shape-the-term.dev at git+https://github.com/jmcavanillas/shape-the-term
Pin and install them? [Y/n] y
[minttea.dev] synchronised (no changes)
minttea is now pinned to git+https://github.com/leostera/minttea (version dev)
[riot.dev] synchronised (no changes)
riot is now pinned to git+https://github.com/riot-ml/riot (version dev)
Package shape-the-term does not exist, create as a NEW package? [Y/n] y
[shape-the-term.dev] synchronised (no changes)
shape-the-term is now pinned to git+https://github.com/jmcavanillas/shape-the-term (version dev)
github_tui is now pinned to git+file:///home/chshersh/ocaml/github-tui#chshersh/fix-ci (version ~dev)

<><> Installing new switch packages <><><><><><><><><><><><><><><><><><><><><><>
Switch invariant: ["ocaml" {>= "4.05.0"}]
[ERROR] Could not determine which packages to install for this switch:
  * Missing dependency:
    - riot = 0.0.8
    not available because the package is pinned to version dev


Switch initialisation failed: clean up? ('n' will leave the switch partially installed) [Y/n] y

@chshersh
Copy link
Author

Unfortunately, even with this fix it doesn't compile. Not sure why because the OCaml code in minttea looks legit.

[ERROR] The compilation of minttea.dev failed at "dune build -p minttea -j 7 @install".

#=== ERROR while compiling minttea.dev ========================================#
# context     2.1.5 | linux/x86_64 | ocaml.5.2.1 | pinned(git+https://github.com/chshersh/minttea#20286772b1d0399f0af3374da3b6f62b1b00879a)
# path        ~/ocaml/github-tui/_opam/.opam-switch/build/minttea.dev
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p minttea -j 7 @install
# exit-code   1
# env-file    ~/.opam/log/minttea-41731-113f0f.env
# output-file ~/.opam/log/minttea-41731-113f0f.out
### output ###
# 112 |   let Config.{ render_mode; fps } = config in
# [...]
# Error: Unbound record field "fps"
# (cd _build/default && /home/chshersh/ocaml/github-tui/_opam/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I minttea/.minttea.objs/byte -I /home/chshersh/ocaml/github-tui/_opam/lib/angstrom -I /home/chshersh/ocaml/github-tui/_opam/lib/asn1-combinators -I /home/chshersh/ocaml/github-tui/_opam/lib/base64 -I /home/chshersh/ocaml/github-tui/_opam/lib/bigstringaf -I /home/chshersh/oca[...]
# File "minttea/minttea.ml", line 8, characters 61-72:
# 8 | let config ?(render_mode = `clear) ?(fps = 60) () = Config.{ render_mode; fps }
#                                                                  ^^^^^^^^^^^
# Error: Unbound record field "render_mode"
# (cd _build/default && /home/chshersh/ocaml/github-tui/_opam/bin/ocamlopt.opt -w -40 -g -I minttea/.minttea.objs/byte -I minttea/.minttea.objs/native -I /home/chshersh/ocaml/github-tui/_opam/lib/angstrom -I /home/chshersh/ocaml/github-tui/_opam/lib/asn1-combinators -I /home/chshersh/ocaml/github-tui/_opam/lib/base64 -I /home/chshersh/ocaml/github-tui/_opam/lib/bigstringaf -I /home/chshersh/oca[...]
# File "minttea/renderer.ml", line 112, characters 28-31:
# 112 |   let Config.{ render_mode; fps } = config in
#                                   ^^^
# Error: Unbound record field "fps"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant