Skip to content

Sync development with main, update #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Mar 24, 2024
Merged

Sync development with main, update #1014

merged 35 commits into from
Mar 24, 2024

Conversation

pomianowski
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

koal44 and others added 30 commits February 29, 2024 17:03
A fair amount of reflection was needed to support columnheader dragging
… _desiredWidth

It turns out that the base methods for GridViewRow presenters can handle all the logic if _desiredWidth is preemptively adjusted
style ListViewItem to a custom one
semove global styling of GridViewColumnHeader

In this way, a user using ListView will see the vanilla version and when using ui:ListiView, ui:GridView and ui:GridViewColumn - they will see the ui library version
Call VisualStateManager.GoToState once the control has loaded

Closes #741
Fix NavigationView pane not closed by default when using IsPaneOpen="False"
…and avoid lazy loading for the collections due to XAML parsing issues

Lazy loading of the collections won't work because, with the introduction of the dependency properties, XAML parsing bypasses the CLR property wrappers, leading to null collections and errors.
koal44 and others added 4 commits March 24, 2024 10:48
- Logic for drag resizing was already baked into the GridViewHeaderRow so all that was needed was a suitable style that used template parts (PART_HeadGripper)
- Styling the indicator required reflection because wpf framework creates the separator control in code via internal OnPreApplyTemplate() and private AddIndicator() methods
@pomianowski pomianowski self-assigned this Mar 24, 2024
@github-actions github-actions bot added themes Topic is related to managing themes controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request icons Fonts and icons updates gallery WPF UI Gallery dotnet release tray labels Mar 24, 2024
@pomianowski pomianowski merged commit bf3c4a6 into main Mar 24, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
controls Changes to the appearance or logic of custom controls. dotnet gallery WPF UI Gallery icons Fonts and icons updates PR Pull request release styles Topic is related to styles themes Topic is related to managing themes tray
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants