Fixed the FontIcon markup extension #1026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
So: I haven't watched the classes because I haven't had time lately. Luckily I have a few days.
That's why I now looked at the markup class.
Markup extensions in XAML require a default constructor with no parameters.
This is missing in the implementation because both constructors expect parameters.
And the most important:
Initializing the FontFamily property twice is not necessary and can lead to problems (which was probably the reason why the FontFamily was only recognized after the line was manually deleted and reinserted) especially if a user sets a different value to FontFamily hands over.
Issue Number: N/A
What is the new behavior?
Now the FontIcon class should work as expected.
Should fix #666 and #986
#163 is a bug inside the tilebar and to directly connected to the FontIcon class itself.
Other information
I would like to reafactor the code. Right now it's harder to follow up as it needs to be and the readability suffers greatly as a result. What do you say?