Merge development and bump version #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @koal44 pointed out, #1012 introduced a bug which made the app crash when using FluentLeft navigation because updating the visual state tries to animate a width to or from OpenPaneLength=NaN. To avoid this, don't try to change the visual state for navigation view modes that don't have an open and a compact state.
TitleBarButton: Fix Foreground not using property value at initial
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 4 to 5. - [Release notes](https://github.com/actions/configure-pages/releases) - [Commits](actions/configure-pages@v4...v5) --- updated-dependencies: - dependency-name: actions/configure-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…pment/actions/configure-pages-5 Bump actions/configure-pages from 4 to 5
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.3 to 2. - [Release notes](https://github.com/microsoft/setup-msbuild/releases) - [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md) - [Commits](microsoft/setup-msbuild@v1.3...v2) --- updated-dependencies: - dependency-name: microsoft/setup-msbuild dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…pment/microsoft/setup-msbuild-2 Bump microsoft/setup-msbuild from 1.3 to 2
* Fix null analyzer complaints: CS8602, CS8618, CS8603, CS8622, IDE0031 * Hide warnings related to IDE0008 related to using `var` keyword * Removed Coersion logic from IconSourceElementConverter, and placed in IconElement and IcounSourceElement classes instead * Cleaning single-line warnings: SA1005 - Removed commented-out Toolbox attributes - Replaced single-line commented-out code with multi-line * Fix missing braces or single-lined braces - Add stylecop supression of 1502 "element should not be on a single line" - Wrap with braces where needed * Fix warnings on registered dependency properties WPF0100, WPF0005, WPF0012 * Fix documentation warnings WPF0108, WPF0060, SA1642, SA1623 * Fix warnings about using language keywords - Use string, double, int rather than String, Double, Int32, etc - remove 'this' keyword when context is obvious * Fix warnings where attributes are on a single line SA1133 * When setting DPs, favor SetCurrentValue over the CLR setter. WPF0041 * Remove unnecessary things (parenthesis, assignments, etc). SA1119, IDE0059 * Fix order of operation warnings * Do not use regions SA1124. Clean VirtualizingPanelBase of warnings * Turn protected control fields into protected properties. fix some documentation warnings * Cleanup warnings in Interop classes and suppress warnings related to uper-casing and private fields * Continue cleaning up warnings in Wpf.Ui * Edit .editorconfig to suppress warnings related to valueconverters * Cleanup warning related to 'var' * Fix warnings * Split ContextMenu style from its loader dictionary There were some issue when having a class called ContextMenu that wasn't actually a contextmenu but a ResourceDictionary * Resolve "expression value is never used" IDE0058 warnings * Fix warnings related to collection initialization. There's still a lot of IDE0028 warnings as the auto fix really wants to use the C#12 collection expressions, which btw will trigger SA1010 warnings (DotNetAnalyzers/StyleCopAnalyzers#3687) * Remove unused suppressions * Supress IDE0290 (Use primary constructor). Just didn't seem necessary. * IDE0009 should be configured through dotnet_styles * Separate out the loader component from the Menu.xaml style. Justification: Menu was not a control.Menu, it's more like a hack to change private api settings. * Fix warnings on NavigationView.NavigationParent attached property * Fix warnings related to setting refernce types as default values. for dependency properties. Also fixed some enum warnings * Fix warnings * Fix regression error where the ContentDialog wouldn't appear and change name of ContentPresenter to DialogHost * Remove obsolete forceBacground parameters. Breaking changes * Remove redundant #if DEBUG directives around Debug.WriteLine calls * Fix some analyzer warnings
…on style. (#1040) Co-authored-by: pomian <[email protected]>
github-actions
bot
added
documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces: