Skip to content

Fix incorrectly refactored High Contrast theme dictionary selection #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2024
Merged

Fix incorrectly refactored High Contrast theme dictionary selection #1063

merged 2 commits into from
Apr 20, 2024

Conversation

Difegue
Copy link
Contributor

@Difegue Difegue commented Apr 19, 2024

This was broken in c0ace5b

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Selecting the Desert HC theme picks one of the dark HC themes instead

Issue Number: N/A

What is the new behavior?

  • Selecting Desert works again

Other information

@Difegue Difegue requested a review from pomianowski as a code owner April 19, 2024 13:38
@github-actions github-actions bot added themes Topic is related to managing themes PR Pull request dotnet release labels Apr 19, 2024
@pomianowski pomianowski changed the base branch from main to development April 19, 2024 17:37
@pomianowski pomianowski merged commit d88b815 into lepoco:development Apr 20, 2024
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pomianowski pomianowski pomianowski approved these changes

@Taiizor Taiizor Taiizor approved these changes

Assignees
No one assigned
Labels
dotnet PR Pull request release themes Topic is related to managing themes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Difegue @pomianowski @Taiizor