Skip to content

fix: PlaceholderText may not display promptly under certain circumstances #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

textGamex
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When we set PlaceholderEnabled from false to true, if the Text is empty, the PlaceholderText will not display immediately; it will only appear after the OnTextChanged method is triggered.

Issue Number: N/A

What is the new behavior?

  • A new callback function, OnPlaceholderEnabledChanged, has been added. When PlaceholderEnabled is set from false to true, if the Text is empty, the PlaceholderText will be displayed immediately, and vice versa.

Other information

@textGamex textGamex requested a review from pomianowski as a code owner June 7, 2024 18:14
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet labels Jun 7, 2024
@textGamex textGamex marked this pull request as draft June 7, 2024 18:14
@textGamex textGamex marked this pull request as ready for review June 7, 2024 18:16
@pomianowski pomianowski merged commit 150e05d into lepoco:development Jun 8, 2024
2 checks passed
@textGamex textGamex deleted the fix-placeholder branch June 9, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet PR Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants